From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751518AbcB2VIH (ORCPT ); Mon, 29 Feb 2016 16:08:07 -0500 Received: from mail-qg0-f65.google.com ([209.85.192.65]:35665 "EHLO mail-qg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbcB2VID (ORCPT ); Mon, 29 Feb 2016 16:08:03 -0500 Date: Mon, 29 Feb 2016 16:08:00 -0500 From: Tejun Heo To: Al Viro Cc: Tahsin Erdogan , Jan Kara , Jens Axboe , cgroups@vger.kernel.org, "Theodore Ts'o" , Nauman Rafique , linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH block/for-linus] writeback: flush inode cgroup wb switches instead of pinning super_block Message-ID: <20160229210800.GY3965@htj.duckdns.org> References: <20160216182457.GO3741@mtj.duckdns.org> <20160217205721.GE14140@quack.suse.cz> <20160217210744.GA6479@mtj.duckdns.org> <20160217223009.GN14140@quack.suse.cz> <20160217230231.GC6479@mtj.duckdns.org> <20160229204724.GV3965@htj.duckdns.org> <20160229205428.GB17997@ZenIV.linux.org.uk> <20160229205837.GX3965@htj.duckdns.org> <20160229210614.GC17997@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160229210614.GC17997@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 29, 2016 at 09:06:15PM +0000, Al Viro wrote: > > Hmmm? The flushing is done after shrink_dcache_for_umount() and > > sync_filesystems(). Aren't inodes supposed to stay clean after that? > > s/shrink_dcache_for_umount/fsnotify_unmount_inodes/ - sorry. Is that allowed to dirty indoes and initiate writebacks again, after sync_filesystems() is done? That sounds weird but it's trivial to move cgroup_writeback_umount() below that if so. Thanks. -- tejun