From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752905AbcB2WdV (ORCPT ); Mon, 29 Feb 2016 17:33:21 -0500 Received: from ozlabs.org ([103.22.144.67]:42066 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbcB2WdT (ORCPT ); Mon, 29 Feb 2016 17:33:19 -0500 Date: Tue, 1 Mar 2016 09:33:17 +1100 From: Stephen Rothwell To: Dave Hansen Cc: linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, akpm@linux-foundation.org, tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com, peterz@infradead.org, linux-next@vger.kernel.org, deller@gmx.de Subject: Re: [PATCH] [v3] x86, pkeys: fix siginfo ABI breakage from new field Message-ID: <20160301093317.4afe0268@canb.auug.org.au> In-Reply-To: <20160229221733.DC2C56B7@viggo.jf.intel.com> References: <20160229221733.DC2C56B7@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave, On Mon, 29 Feb 2016 14:17:33 -0800 Dave Hansen wrote: > > To fix this, we replace the u64 with an '__u32'. The __u32 is > guaranteed to union well with the pointers from _addr_bnd. It is > also plenty large enough to store the 16-bit pkey we have today > on x86. That looks better, thanks. -- Cheers, Stephen Rothwell