mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Wang Nan <wangnan0@huawei.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: libbabeltrace feature detection message
Date: Tue, 1 Mar 2016 13:51:24 +0100	[thread overview]
Message-ID: <20160301125124.GA26168@krava.redhat.com> (raw)
In-Reply-To: <20160229150720.GC32719@kernel.org>

On Mon, Feb 29, 2016 at 12:07:20PM -0300, Arnaldo Carvalho de Melo wrote:
> 
> Hi Jiri,
> 
> 	While testing a patch by Wang, that requires building with
> libbabeltrace, I noticed that there are no feature detection message
> telling that it was found successfully. The end result is the desired
> one, it builds with babeltrace, but I wonder if we couldn't have the
> [ok] line for it:

well, we removed it, because the latest version if libbabeltrace pkg
perf needs wasn't present in common distros.. so for most users that
would print 'OFF' as a status.. that might have changed now, dont know

anyway, for libbabeltrace and other in FEATURE_TESTS_EXTRA it's not possible
to print their status easily at the moment, because the status isn't known at
the time tools/build/Makefile.feature is included in config/Makefile

I'll check if we can reorg the code a little to get the full status at the end

jirka

> 
> 
> [acme@jouet linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; make LIBBABELTRACE=1 O=/tmp/build/perf -C tools/perf install-bin
> make: Entering directory '/home/acme/git/linux/tools/perf'
>   BUILD:   Doing 'make -j4' parallel build
> 
> Auto-detecting system features:
> ...                         dwarf: [ on  ]
> ...                         glibc: [ on  ]
> ...                          gtk2: [ on  ]
> ...                      libaudit: [ on  ]
> ...                        libbfd: [ on  ]
> ...                        libelf: [ on  ]
> ...                       libnuma: [ on  ]
> ...        numa_num_possible_cpus: [ on  ]
> ...                       libperl: [ on  ]
> ...                     libpython: [ on  ]
> ...                      libslang: [ on  ]
> ...                     libcrypto: [ on  ]
> ...                     libunwind: [ on  ]
> ...            libdw-dwarf-unwind: [ on  ]
> ...                          zlib: [ on  ]
> ...                          lzma: [ on  ]
> ...                     get_cpuid: [ on  ]
> ...                           bpf: [ on  ]
> 
>   GEN      /tmp/build/perf/common-cmds.h
>   CC       /tmp/build/perf/fixdep.o
>   LD       /tmp/build/perf/fixdep-in.o
> <SNIP>
> [acme@jouet linux]$ ldd ~/bin/perf | grep babel
> 	libbabeltrace-ctf.so.1 => /lib64/libbabeltrace-ctf.so.1 (0x00007fce5c405000)
> 	libbabeltrace.so.1 => /lib64/libbabeltrace.so.1 (0x00007fce5bd69000)
> [acme@jouet linux]$ 
> 
> 
> - Arnaldo

  reply	other threads:[~2016-03-01 12:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 15:07 Arnaldo Carvalho de Melo
2016-03-01 12:51 ` Jiri Olsa [this message]
2016-03-01 12:55   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160301125124.GA26168@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome