From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753728AbcCANGi (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Mar 2016 08:06:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50720 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752589AbcCANGh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Mar 2016 08:06:37 -0500
Date: Tue, 1 Mar 2016 14:06:31 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kernel@vger.kernel.org, Aaro Koskinen <aaro.koskinen@nokia.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Lukas Wunner <lukas@wunner.de>, Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH] tools build: use .s extension for preprocessed assembler
 code
Message-ID: <20160301130631.GB26168@krava.redhat.com>
References: <1454263140-19670-1-git-send-email-yamada.masahiro@socionext.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454263140-19670-1-git-send-email-yamada.masahiro@socionext.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 01 Mar 2016 13:06:36 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 01, 2016 at 02:59:00AM +0900, Masahiro Yamada wrote:
> The "man gcc" says .i extension represents the file is C source code
> that should not be preprocessed.  Here, .s should be used.
> 
> For clarification,
>   .c  ---(preprocess)--->  .i
>   .S  ---(preprocess)--->  .s

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  tools/build/Makefile.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index 4a96473..ee566e8 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -85,7 +85,7 @@ $(OUTPUT)%.i: %.c FORCE
>  	$(call rule_mkdir)
>  	$(call if_changed_dep,cc_i_c)
>  
> -$(OUTPUT)%.i: %.S FORCE
> +$(OUTPUT)%.s: %.S FORCE
>  	$(call rule_mkdir)
>  	$(call if_changed_dep,cc_i_c)
>  
> -- 
> 1.9.1
>