From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751563AbcCAWVV (ORCPT ); Tue, 1 Mar 2016 17:21:21 -0500 Received: from ozlabs.org ([103.22.144.67]:38167 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbcCAWVU (ORCPT ); Tue, 1 Mar 2016 17:21:20 -0500 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: abd0a0e7914a1137973119ac3b3cace26e8ffa96 In-Reply-To: <1454988763-5580-2-git-send-email-david@gibson.dropbear.id.au> To: David Gibson , paulus@samba.org, benh@kernel.crashing.org From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, David Gibson Subject: Re: [1/4] powerpc/mm: Clean up error handling for htab_remove_mapping Message-Id: <20160301222118.F3D371402C4@ozlabs.org> Date: Wed, 2 Mar 2016 09:21:18 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-09-02 at 03:32:40 UTC, David Gibson wrote: > Currently, the only error that htab_remove_mapping() can report is -EINVAL, > if removal of bolted HPTEs isn't implemeted for this platform. We make > a few clean ups to the handling of this: > > * EINVAL isn't really the right code - there's nothing wrong with the > function's arguments - use ENODEV instead > * We were also printing a warning message, but that's a decision better > left up to the callers, so remove it > * One caller is vmemmap_remove_mapping(), which will just BUG_ON() on > error, making the warning message redundant, so no change is needed > there. > * The other caller is remove_section_mapping(). This is called in the > memory hot remove path at a point after vmemmap_remove_mapping() so > if hpte_removebolted isn't implemented, we'd expect to have already > BUG()ed anyway. Put a WARN_ON() here, in lieu of a printk() since this > really shouldn't be happening. > > Signed-off-by: David Gibson > Reviewed-by: Aneesh Kumar K.V Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/abd0a0e7914a1137973119ac3b cheers