From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752460AbcCAWXJ (ORCPT ); Tue, 1 Mar 2016 17:23:09 -0500 Received: from ozlabs.org ([103.22.144.67]:35499 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbcCAWVV (ORCPT ); Tue, 1 Mar 2016 17:21:21 -0500 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 1dace6c665ec59bdc4eeafa4db7228c1a673e2e2 In-Reply-To: <1454988763-5580-4-git-send-email-david@gibson.dropbear.id.au> To: David Gibson , paulus@samba.org, benh@kernel.crashing.org From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, David Gibson Subject: Re: [3/4] powerpc/mm: Clean up memory hotplug failure paths Message-Id: <20160301222119.ABDE3140B0D@ozlabs.org> Date: Wed, 2 Mar 2016 09:21:19 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-09-02 at 03:32:42 UTC, David Gibson wrote: > This makes a number of cleanups to handling of mapping failures during > memory hotplug on Power: > > For errors creating the linear mapping for the hot-added region: > * This is now reported with EFAULT which is more appropriate than the > previous EINVAL (the failure is unlikely to be related to the > function's parameters) > * An error in this path now prints a warning message, rather than just > silently failing to add the extra memory. > * Previously a failure here could result in the region being partially > mapped. We now clean up any partial mapping before failing. > > For errors creating the vmemmap for the hot-added region: > * This is now reported with EFAULT instead of causing a BUG() - this > could happen for external reason (e.g. full hash table) so it's better > to handle this non-fatally > * An error message is also printed, so the failure won't be silent > * As above a failure could cause a partially mapped region, we now > clean this up. > > Signed-off-by: David Gibson > Reviewed-by: Paul Mackerras > Reviewed-by: Aneesh Kumar K.V Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1dace6c665ec59bdc4eeafa4db cheers