From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754387AbcCBKKY (ORCPT ); Wed, 2 Mar 2016 05:10:24 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:35920 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbcCBKKU (ORCPT ); Wed, 2 Mar 2016 05:10:20 -0500 Date: Wed, 2 Mar 2016 11:10:16 +0100 From: Jiri Pirko To: Arnd Bergmann Cc: Jiri Pirko , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Yishai Hadas , Doug Ledford , Sean Hefty , Hal Rosenstock , Ido Schimmel , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: mellanox: add DEVLINK dependencies Message-ID: <20160302101016.GA2122@nanopsycho.orion> References: <1456911665-1424389-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456911665-1424389-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, Mar 02, 2016 at 10:40:54AM CET, arnd@arndb.de wrote: >The new NET_DEVLINK infrastructure can be a loadable module, but the drivers >using it might be built-in, which causes link errors like: > >drivers/net/built-in.o: In function `mlx4_load_one': >:(.text+0x2fbfda): undefined reference to `devlink_port_register' >:(.text+0x2fc084): undefined reference to `devlink_port_unregister' >drivers/net/built-in.o: In function `mlxsw_sx_port_remove': >:(.text+0x33a03a): undefined reference to `devlink_port_type_clear' >:(.text+0x33a04e): undefined reference to `devlink_port_unregister' > >There are multiple ways to avoid this: > >a) add 'depends on NET_DEVLINK || !NET_DEVLINK' dependencies > for each user >b) use 'select NET_DEVLINK' from each driver that uses it > and hide the symbol in Kconfig. >c) make NET_DEVLINK a 'bool' option so we don't have to > list it as a dependency, and rely on the APIs to be > stubbed out when it is disabled >d) use IS_REACHABLE() rather than IS_ENABLED() to check for > NET_DEVLINK in include/net/devlink.h > >This implements a variation of approach a) by adding an >intermediate symbol that drivers can depend on, and changes >the three drivers using it. Approach a) looks like the best. Thanks for taking care of this. > >Signed-off-by: Arnd Bergmann Acked-by: Jiri Pirko