From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 5/7] perf, tools, stat: Implement --metric-only mode
Date: Wed, 2 Mar 2016 16:35:07 +0100 [thread overview]
Message-ID: <20160302153506.GX5083@two.firstfloor.org> (raw)
In-Reply-To: <20160302115750.GA28054@krava.redhat.com>
> > @@ -1229,6 +1397,8 @@ static void print_counters(struct timespec *ts, int argc, const char **argv)
> > case AGGR_GLOBAL:
> > evlist__for_each(evsel_list, counter)
> > print_counter_aggr(counter, prefix);
> > + if (metric_only)
> > + fputc('\n', stat_config.output);
>
> this new line printing based on metric_only is all over the place..
> could we sorted out new lines in the print callbacks? this makes
> my head hurt ;-)
I don't see how a print callback could handle it. It has no idea
where the event list ends. Only the high level display function
knows that, and it prints the newlines.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2016-03-02 15:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 18:57 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-03-01 18:57 ` [PATCH 1/7] perf, tools, stat: Check existence of frontend/backed stalled cycles Andi Kleen
2016-03-01 18:57 ` [PATCH 2/7] perf, tools, stat: Implement CSV metrics output Andi Kleen
2016-03-01 18:57 ` [PATCH 3/7] perf, tools, stat: Support metrics in --per-core/socket mode Andi Kleen
2016-03-01 18:57 ` [PATCH 4/7] perf, tools, stat: Document CSV format in manpage Andi Kleen
2016-03-02 11:23 ` Jiri Olsa
2016-03-01 18:57 ` [PATCH 5/7] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-03-02 11:57 ` Jiri Olsa
2016-03-02 15:35 ` Andi Kleen [this message]
2016-03-01 18:57 ` [PATCH 6/7] perf, tools, stat: Add --metric-only support for -A Andi Kleen
2016-03-01 18:57 ` [PATCH 7/7] perf, tools, stat: Check for frontend stalled for metrics Andi Kleen
2016-03-02 12:04 ` Jiri Olsa
2016-03-05 8:21 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-03-01 19:05 ` perf, tools: Refactor and support interval and CSV metrics Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2016-03-03 23:57 Andi Kleen
2016-03-03 23:57 ` [PATCH 5/7] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-03-10 11:28 ` Jiri Olsa
2016-03-03 0:24 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-03-03 0:24 ` [PATCH 5/7] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-02-29 22:36 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2016-02-29 22:36 ` [PATCH 5/7] perf, tools, stat: Implement --metric-only mode Andi Kleen
2016-03-01 12:32 ` Jiri Olsa
2016-03-01 14:53 ` Andi Kleen
2016-03-01 12:32 ` Jiri Olsa
2016-03-01 18:51 ` Andi Kleen
2016-03-02 11:28 ` Jiri Olsa
2016-03-02 15:38 ` Andi Kleen
2016-03-02 15:46 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302153506.GX5083@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome