From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sedat Dilek <sedat.dilek@gmail.com>,
Jiri Kosina <jikos@kernel.org>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Andy Lutomirski <luto@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@ti.com>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning
Date: Wed, 2 Mar 2016 17:42:49 +0100 [thread overview]
Message-ID: <20160302164249.GJ6357@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160302113535.6abe9a2c@gandalf.local.home>
On Wed, Mar 02, 2016 at 11:35:35AM -0500, Steven Rostedt wrote:
> On Wed, 2 Mar 2016 17:24:12 +0100
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Wed, Mar 02, 2016 at 04:53:36PM +0100, Sedat Dilek wrote:
> > > ffffffff8110f570 <del_timer_sync>:
> > > ffffffff8110f570: 55 push %rbp
> > > ffffffff8110f571: 48 89 e5 mov %rsp,%rbp
> > > ffffffff8110f574: 41 57 push %r15
> > > ffffffff8110f576: 41 56 push %r14
> > > ffffffff8110f578: 53 push %rbx
> > > ffffffff8110f579: 48 83 ec 28 sub $0x28,%rsp
> >
> > stack offset is 0x28 bytes [*]
>
> Actually, isn't it really 0x40 bytes? The stack pushed 3 words (8 bytes
> each) before doing the subtract. 0x28 == 40 bytes, 3 * 8 = 24,
> 40 + 24 = 64 == 0x40.
> > > ffffffff8110f5fd: 4c 89 75 d0 mov %r14,-0x30(%rbp)
> > > ffffffff8110f601: ff 75 d0 pushq -0x30(%rbp)
> > > ffffffff8110f604: 9d popfq
> >
> > put r14 into -0x30(rbp) and pushes/pops that, see [*] this is 8 bytes
> > over stack ?!
>
> But from rbp, the stack is 0x40 bytes. This may be fine.
Ah indeed.
next prev parent reply other threads:[~2016-03-02 16:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1443427804-2957-1-git-send-email-sedat.dilek@gmail.com>
[not found] ` <alpine.LNX.2.00.1509281329261.30132@pobox.suse.cz>
[not found] ` <CA+icZUWXcNue2kx0nLzAmJeaYVgcpqT3Zz8cuRkQDcT93n4U+w@mail.gmail.com>
[not found] ` <alpine.LNX.2.00.1509291117280.30132@pobox.suse.cz>
[not found] ` <CA+icZUWH2vR_vpYu4hCS578U3ssmoiF0pLYUfM-Xo-57e8uN=g@mail.gmail.com>
[not found] ` <alpine.LNX.2.00.1509300918090.30132@pobox.suse.cz>
[not found] ` <20150930045655.1c52eecd@gandalf.local.home>
[not found] ` <CA+icZUUnoD8_=Wm+OM2pN0ZS-rwqjLHtTw5xCWe5epNqSTZSiQ@mail.gmail.com>
[not found] ` <20150930061351.06f06abd@gandalf.local.home>
[not found] ` <CA+icZUXSzScTmMgLZwPQq9RMH9cUsD5_iDxKTVuG0rrGqH-8Cw@mail.gmail.com>
[not found] ` <20150930220153.7a75c4fc@grimm.local.home>
[not found] ` <CA+icZUV7pxXoApuLdc7Z=kMHiKG=diHNqsnR5-MHpER=XkjQVQ@mail.gmail.com>
[not found] ` <CA+icZUUyaHqHP2v52juhGhoTNS9xX7LT2YxkOppLz6f9Z+FBEA@mail.gmail.com>
[not found] ` <CA+icZUWagGMVNs5gBPRBhYO0LsY2A1hK3KSLabp9ZpDVOTmtig@mail.gmail.com>
[not found] ` <20151012205755.7ad86f4c@grimm.local.home>
2016-03-01 10:05 ` Sedat Dilek
2016-03-01 15:07 ` Steven Rostedt
2016-03-01 15:17 ` Peter Zijlstra
2016-03-02 15:00 ` Sedat Dilek
2016-03-02 15:17 ` Peter Zijlstra
2016-03-02 15:34 ` Sedat Dilek
2016-03-02 15:53 ` Sedat Dilek
2016-03-02 15:56 ` Steven Rostedt
2016-03-02 16:08 ` Sedat Dilek
2016-03-02 16:11 ` Sedat Dilek
2016-03-02 16:21 ` Sedat Dilek
2016-03-02 16:24 ` Peter Zijlstra
2016-03-02 16:35 ` Steven Rostedt
2016-03-02 16:42 ` Peter Zijlstra [this message]
2016-03-02 16:42 ` Sedat Dilek
2016-03-02 16:52 ` Sedat Dilek
2016-03-01 15:59 ` Alan Stern
2016-03-02 6:25 ` Sedat Dilek
2016-03-04 16:04 ` Alan Stern
2016-03-05 22:30 ` Sedat Dilek
2016-03-06 8:51 ` Sedat Dilek
2016-03-06 17:23 ` Alan Stern
2016-03-02 6:36 ` Sedat Dilek
2016-03-02 8:34 ` Sedat Dilek
2016-03-02 8:37 ` Jiri Kosina
2016-03-02 9:11 ` Sedat Dilek
2016-03-07 15:59 Sedat Dilek
2016-03-07 16:28 ` Sedat Dilek
2016-03-07 16:41 ` Alan Stern
2016-03-07 17:03 ` Steven Rostedt
2016-03-07 17:05 ` Jiri Kosina
2016-03-07 17:15 ` Sedat Dilek
2016-03-07 17:27 ` David Laight
2016-03-07 18:07 ` Alan Stern
2016-03-07 18:30 ` Linus Torvalds
2016-06-27 19:50 ` Sedat Dilek
2016-06-27 20:03 ` Sedat Dilek
2016-06-27 20:14 ` Linus Torvalds
2016-06-27 20:27 ` Sedat Dilek
2016-06-27 20:36 ` Linus Torvalds
2016-03-07 17:11 ` Steven Rostedt
2016-03-07 17:18 ` Sedat Dilek
2016-03-07 17:24 ` Jiri Kosina
2016-03-07 17:30 ` Steven Rostedt
2016-03-07 18:04 ` Andy Lutomirski
2016-03-07 19:10 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302164249.GJ6357@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=balbi@ti.com \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiangshanlai@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=sedat.dilek@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®