From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754099AbcCBWkz (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Mar 2016 17:40:55 -0500
Received: from mail.skyhub.de ([78.46.96.112]:54866 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752237AbcCBWky (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Mar 2016 17:40:54 -0500
Date: Wed, 2 Mar 2016 23:40:47 +0100
From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Brian Gerst <brgerst@gmail.com>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [RFC PATCH] x86: Make sure verify_cpu has a good stack
Message-ID: <20160302224047.GN8362@pd.tnic>
References: <20160302181556.GD8362@pd.tnic>
 <56D73349.3020609@zytor.com>
 <20160302195053.GG8362@pd.tnic>
 <56D75C8D.90800@zytor.com>
 <20160302214654.GK8362@pd.tnic>
 <56D7612A.4080107@zytor.com>
 <20160302220954.GL8362@pd.tnic>
 <56D76527.5020806@zytor.com>
 <20160302222842.GM8362@pd.tnic>
 <EFC40C33-9525-409C-B57B-A70BC5F00C1B@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <EFC40C33-9525-409C-B57B-A70BC5F00C1B@zytor.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 02, 2016 at 02:32:54PM -0800, H. Peter Anvin wrote:
> I'm trying to think of any reason why we couldn't simply have a symbol
> at the top of the initial stack? Then a simple leaq would suffice;
> this is for the BSP after all.

That should be simpler. And we do games like that already in the trampoline:

        # Setup stack
        movl    $rm_stack_end, %esp

...

GLOBAL(rm_stack)
        .space  2048
GLOBAL(rm_stack_end)

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.