From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753249AbcCBXd1 (ORCPT ); Wed, 2 Mar 2016 18:33:27 -0500 Received: from down.free-electrons.com ([37.187.137.238]:60481 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750917AbcCBXd0 (ORCPT ); Wed, 2 Mar 2016 18:33:26 -0500 Date: Thu, 3 Mar 2016 00:33:23 +0100 From: Alexandre Belloni To: Laxman Dewangan Cc: k.kozlowski@samsung.com, a.zummo@towertech.it, cw00.choi@samsung.com, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, javier@osg.samsung.com, rklein@nvidia.com Subject: Re: [PATCH V2 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP Message-ID: <20160302233323.GB2567@piout.net> References: <1456907785-11942-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456907785-11942-1-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/2016 at 14:06:24 +0530, Laxman Dewangan wrote : > Maxim Semiconductor's PMIC MAX77686 has RTC IP which is > reused in the MAX77620/MAX20024 PMICs. > > Add support for these devices in MAX77686 RTC driver. This > device does not have RTC alarm pending status outside of > RTC IP. The RTC IP is having separate I2C address for its > register access. > > Signed-off-by: Laxman Dewangan > --- > Changes from V1: > - Remove macro and use value directly. > - Handle error returned from platform_get_irq() > - Remove compatible for max77620. > - Cleanup like indenting. > > drivers/rtc/Kconfig | 4 ++-- > drivers/rtc/rtc-max77686.c | 47 +++++++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 46 insertions(+), 5 deletions(-) > Both applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com