From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754863AbcCCAMa (ORCPT ); Wed, 2 Mar 2016 19:12:30 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:43219 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752672AbcCCAM3 (ORCPT ); Wed, 2 Mar 2016 19:12:29 -0500 Date: Thu, 3 Mar 2016 09:12:25 +0900 From: Simon Horman To: Geert Uytterhoeven Cc: Kishon Vijay Abraham I , Yoshihiro Shimoda , Magnus Damm , "linux-kernel@vger.kernel.org" , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] phy: rcar-gen3-usb2, rcar-gen2: Use ARCH_RENESAS Message-ID: <20160303001224.GE23040@verge.net.au> References: <1456885514-27466-1-git-send-email-horms+renesas@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2016 at 10:36:33AM +0100, Geert Uytterhoeven wrote: > On Wed, Mar 2, 2016 at 3:25 AM, Simon Horman wrote: > > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > > > Signed-off-by: Simon Horman > > Acked-by: Geert Uytterhoeven > > > --- a/drivers/phy/Kconfig > > +++ b/drivers/phy/Kconfig > > @@ -113,14 +113,14 @@ config PHY_MIPHY365X > > > > config PHY_RCAR_GEN2 > > tristate "Renesas R-Car generation 2 USB PHY driver" > > - depends on ARCH_SHMOBILE > > + depends on ARCH_RENESAS > > depends on GENERIC_PHY > > help > > Support for USB PHY found on Renesas R-Car generation 2 SoCs. > > > > config PHY_RCAR_GEN3_USB2 > > tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" > > - depends on OF && ARCH_SHMOBILE > > + depends on OF && ARCH_RENESAS > > FWIW, you may want to drop the dependency on OF, as this is implied by > ARCH_RENESAS. > Or you can handle that when adding/testing COMPILE_TEST support ;-) So the ideal setup would be as follows? depends on ARCH_RENESAS || (OF && COMPILE_TEST) If so I think I would like to update this patch to: depends on ARCH_RENESAS And then deal with COMPILE_TEST separately: I should probably sweep the tree for Renesas related drivers that do have a COMPILE_TEST dependency. > > select GENERIC_PHY > > help > > Support for USB 2.0 PHY found on Renesas R-Car generation 3 SoCs. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds