From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755382AbcCCAN0 (ORCPT ); Wed, 2 Mar 2016 19:13:26 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:43226 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755176AbcCCANY (ORCPT ); Wed, 2 Mar 2016 19:13:24 -0500 Date: Thu, 3 Mar 2016 09:13:20 +0900 From: Simon Horman To: Geert Uytterhoeven Cc: Kishon Vijay Abraham I , Yoshihiro Shimoda , Magnus Damm , "linux-kernel@vger.kernel.org" , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 1/2] phy: rcar-gen2: add fallback binding Message-ID: <20160303001320.GF23040@verge.net.au> References: <1456886237-29936-1-git-send-email-horms+renesas@verge.net.au> <1456886237-29936-2-git-send-email-horms+renesas@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2016 at 10:37:31AM +0100, Geert Uytterhoeven wrote: > On Wed, Mar 2, 2016 at 3:37 AM, Simon Horman wrote: > > In the case of Renesas R-Car hardware we know that there are generations of > > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the > > relationship between IP blocks might be. For example, I believe that > > r8a7790 is older than r8a7791 but that doesn't imply that the latter is a > > descendant of the former or vice versa. > > > > We can, however, by examining the documentation and behaviour of the > > hardware at run-time observe that the current driver implementation appears > > to be compatible with the IP blocks on SoCs within a given generation. > > > > For the above reasons and convenience when enabling new SoCs a > > per-generation fallback compatibility string scheme being adopted for > > drivers for Renesas SoCs. > > > > Signed-off-by: Simon Horman > > > --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > > +++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > > @@ -7,6 +7,12 @@ Required properties: > > - compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. > > "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. > > "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC. > > + "renesas,usb-phy-gen2" for a generic R-Car Gen2 compatible device. > > "renesas,rcar-gen2-usb-phy"? I seem to always get these backwards first go :( I'll update this and the following patch as you suggest.