From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757872AbcCCOM4 (ORCPT ); Thu, 3 Mar 2016 09:12:56 -0500 Received: from smtprelay0024.hostedemail.com ([216.40.44.24]:54723 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752458AbcCCOMy (ORCPT ); Thu, 3 Mar 2016 09:12:54 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3872:3873:3874:3876:4321:4362:5007:6261:7875:7901:9040:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12517:12519:12555:12740:13069:13311:13357:13439:14659:21080:21212:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: crow18_3623d491d2812 X-Filterd-Recvd-Size: 2084 Date: Thu, 3 Mar 2016 09:12:50 -0500 From: Steven Rostedt To: Pratyush Anand Cc: linux-kernel@vger.kernel.org, linux-rt-users , Thomas Gleixner , Carsten Emde , Sebastian Andrzej Siewior , John Kacur , Paul Gortmaker , stable-rt@vger.kernel.org, Yang Shi Subject: Re: [PATCH RT 07/17] arm64: replace read_lock to rcu lock in call_step_hook Message-ID: <20160303091250.09034e47@gandalf.local.home> In-Reply-To: <20160303042300.GA32034@dhcppc3> References: <20160302154433.638594715@goodmis.org> <20160302154500.885242090@goodmis.org> <20160303042300.GA32034@dhcppc3> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Mar 2016 09:53:00 +0530 Pratyush Anand wrote: > > diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c > > index 636ba8b6240b..f66d668ffce9 100644 > > --- a/arch/arm64/kernel/debug-monitors.c > > +++ b/arch/arm64/kernel/debug-monitors.c > > @@ -190,19 +190,22 @@ static void clear_regs_spsr_ss(struct pt_regs *regs) > > /* EL1 Single Step Handler hooks */ > > static LIST_HEAD(step_hook); > > DEFINE_RWLOCK(step_hook_lock); > > +static DEFINE_RWLOCK(step_hook_lock); > > I think, this got wrong during backporting, no? > Should have been > -DEFINE_RWLOCK(step_hook_lock); > Crap! Yep you are right. I screwed this up. I'll go fix it. Luckily, that patch ended there. It didn't affect 3.12 or earlier. Thanks for catching that. -- Steve > > +static DEFINE_SPINLOCK(step_hook_lock); > > ~Pratyush