From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754735AbcCCMjp (ORCPT ); Thu, 3 Mar 2016 07:39:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43946 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751407AbcCCMjo (ORCPT ); Thu, 3 Mar 2016 07:39:44 -0500 Date: Thu, 3 Mar 2016 13:39:39 +0100 From: Jiri Olsa To: Colin King Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Wang Nan , He Kuang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: explicitly declare inc_group_count as a void function Message-ID: <20160303123939.GA1466@krava.redhat.com> References: <1457008214-14393-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457008214-14393-1-git-send-email-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2016 at 12:30:14PM +0000, Colin King wrote: > From: Colin Ian King > > The return type is not defined, so it defaults to int, however, > the function is not returning anything, so this is clearly not > correct. Make it a void function. Acked-by: Jiri Olsa thanks, jirka > > Signed-off-by: Colin Ian King > --- > tools/perf/util/parse-events.y | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y > index 85c44ba..5be4a5f 100644 > --- a/tools/perf/util/parse-events.y > +++ b/tools/perf/util/parse-events.y > @@ -28,7 +28,7 @@ do { \ > INIT_LIST_HEAD(list); \ > } while (0) > > -static inc_group_count(struct list_head *list, > +static void inc_group_count(struct list_head *list, > struct parse_events_evlist *data) > { > /* Count groups only have more than 1 members */ > -- > 2.7.0 >