From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758090AbcCCPML (ORCPT ); Thu, 3 Mar 2016 10:12:11 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:41196 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190AbcCCPMJ (ORCPT ); Thu, 3 Mar 2016 10:12:09 -0500 From: Juergen Borleis Organization: Pengutronix e.K. To: Alexandre Belloni Subject: Re: [PATCH 2/2] rtc: pcf85063: remove struct pcf85063 Date: Thu, 3 Mar 2016 16:14:08 +0100 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org References: <1456914343-4611-1-git-send-email-alexandre.belloni@free-electrons.com> <1456914343-4611-2-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1456914343-4611-2-git-send-email-alexandre.belloni@free-electrons.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201603031614.08309.jbe@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: jbe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 02 March 2016 11:25:43 Alexandre Belloni wrote: > No members of struct pcf85063 are used anymore, remove the whole structure. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/rtc-pcf85063.c | 22 +++++----------------- > 1 file changed, 5 insertions(+), 17 deletions(-) > > diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c > index 550f67518c5a..e8ddbb359d11 100644 > --- a/drivers/rtc/rtc-pcf85063.c > +++ b/drivers/rtc/rtc-pcf85063.c > @@ -31,11 +31,6 @@ > > static struct i2c_driver pcf85063_driver; > > -struct pcf85063 { > - struct rtc_device *rtc; > - int voltage_low; /* indicates if a low_voltage was detected */ > -}; > - > static int pcf85063_stop_clock(struct i2c_client *client, u8 *ctrl1) > { > s32 ret; > @@ -168,25 +163,18 @@ static const struct rtc_class_ops pcf85063_rtc_ops = { > static int pcf85063_probe(struct i2c_client *client, > const struct i2c_device_id *id) > { > - struct pcf85063 *pcf85063; > + struct rtc_device *rtc; > > dev_dbg(&client->dev, "%s\n", __func__); > > if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) > return -ENODEV; > > - pcf85063 = devm_kzalloc(&client->dev, sizeof(struct pcf85063), > - GFP_KERNEL); > - if (!pcf85063) > - return -ENOMEM; > - > - i2c_set_clientdata(client, pcf85063); > - > - pcf85063->rtc = devm_rtc_device_register(&client->dev, > - pcf85063_driver.driver.name, > - &pcf85063_rtc_ops, THIS_MODULE); > + rtc = devm_rtc_device_register(&client->dev, > + pcf85063_driver.driver.name, > + &pcf85063_rtc_ops, THIS_MODULE); > > - return PTR_ERR_OR_ZERO(pcf85063->rtc); > + return PTR_ERR_OR_ZERO(rtc); > } > > static const struct i2c_device_id pcf85063_id[] = { Reviewed-by: Juergen Borleis jb