Re: [PATCH 7/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6945 bytes --]

Hi Lu,

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.5-rc6 next-20160303]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Lu-Baolu/usb-add-support-for-Intel-dual-role-port-mux/20160303-144241
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: mn10300-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=mn10300 

All error/warnings (new ones prefixed by >>):

   drivers/mfd/intel-vuport.c: In function 'vuport_probe':
   drivers/mfd/intel-vuport.c:39:17: warning: unused variable 'dev' [-Wunused-variable]
     struct device *dev = &pdev->dev;
                    ^
   drivers/mfd/intel-vuport.c: At top level:
>> drivers/mfd/intel-vuport.c:63:1: warning: data definition has no type or storage class
    MODULE_DEVICE_TABLE(acpi, vuport_acpi_match);
    ^
>> drivers/mfd/intel-vuport.c:63:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
>> drivers/mfd/intel-vuport.c:63:1: warning: parameter names (without types) in function declaration
   In file included from include/linux/acpi.h:27:0,
                    from drivers/mfd/intel-vuport.c:12:
   include/linux/device.h:1337:1: warning: data definition has no type or storage class
    module_init(__driver##_init); \
    ^
   include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
     module_driver(__platform_driver, platform_driver_register, \
     ^
   drivers/mfd/intel-vuport.c:75:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(vuport_driver);
    ^
   include/linux/device.h:1337:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
    module_init(__driver##_init); \
    ^
   include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
     module_driver(__platform_driver, platform_driver_register, \
     ^
   drivers/mfd/intel-vuport.c:75:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(vuport_driver);
    ^
   drivers/mfd/intel-vuport.c:75:1: warning: parameter names (without types) in function declaration
   In file included from include/linux/acpi.h:27:0,
                    from drivers/mfd/intel-vuport.c:12:
   include/linux/device.h:1342:1: warning: data definition has no type or storage class
    module_exit(__driver##_exit);
    ^
   include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
     module_driver(__platform_driver, platform_driver_register, \
     ^
   drivers/mfd/intel-vuport.c:75:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(vuport_driver);
    ^
   include/linux/device.h:1342:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
    module_exit(__driver##_exit);
    ^
   include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
     module_driver(__platform_driver, platform_driver_register, \
     ^
   drivers/mfd/intel-vuport.c:75:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(vuport_driver);
    ^
   drivers/mfd/intel-vuport.c:75:1: warning: parameter names (without types) in function declaration
>> drivers/mfd/intel-vuport.c:77:15: error: expected declaration specifiers or '...' before string constant
    MODULE_AUTHOR("Lu Baolu <baolu.lu@linux.intel.com>");
                  ^
   drivers/mfd/intel-vuport.c:78:20: error: expected declaration specifiers or '...' before string constant
    MODULE_DESCRIPTION("Intel virtual USB port");
                       ^
   drivers/mfd/intel-vuport.c:79:16: error: expected declaration specifiers or '...' before string constant
    MODULE_LICENSE("GPL v2");
                   ^
   drivers/mfd/intel-vuport.c:59:30: warning: 'vuport_acpi_match' defined but not used [-Wunused-variable]
    static struct acpi_device_id vuport_acpi_match[] = {
                                 ^
   In file included from include/linux/acpi.h:27:0,
                    from drivers/mfd/intel-vuport.c:12:
   drivers/mfd/intel-vuport.c:75:24: warning: 'vuport_driver_init' defined but not used [-Wunused-function]
    module_platform_driver(vuport_driver);
                           ^
   include/linux/device.h:1333:19: note: in definition of macro 'module_driver'
    static int __init __driver##_init(void) \
                      ^
   drivers/mfd/intel-vuport.c:75:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(vuport_driver);
    ^
   drivers/mfd/intel-vuport.c:75:24: warning: 'vuport_driver_exit' defined but not used [-Wunused-function]
    module_platform_driver(vuport_driver);
                           ^
   include/linux/device.h:1338:20: note: in definition of macro 'module_driver'
    static void __exit __driver##_exit(void) \
                       ^
   drivers/mfd/intel-vuport.c:75:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(vuport_driver);
    ^
   cc1: some warnings being treated as errors

vim +63 drivers/mfd/intel-vuport.c

    33			.name = "intel-mux-gpio",
    34		},
    35	};
    36	
    37	static int vuport_probe(struct platform_device *pdev)
    38	{
  > 39		struct device *dev = &pdev->dev;
    40		int ret;
    41	
    42		ret = acpi_dev_add_driver_gpios(ACPI_COMPANION(dev), acpi_usb_gpios);
    43		if (ret)
    44			return ret;
    45	
    46		return mfd_add_devices(&pdev->dev, 0, intel_vuport_mfd_cells,
    47				ARRAY_SIZE(intel_vuport_mfd_cells), NULL, 0,
    48				NULL);
    49	}
    50	
    51	static int vuport_remove(struct platform_device *pdev)
    52	{
    53		mfd_remove_devices(&pdev->dev);
    54		acpi_dev_remove_driver_gpios(ACPI_COMPANION(&pdev->dev));
    55	
    56		return 0;
    57	}
    58	
    59	static struct acpi_device_id vuport_acpi_match[] = {
    60		{ "INT3496" },
    61		{ }
    62	};
  > 63	MODULE_DEVICE_TABLE(acpi, vuport_acpi_match);
    64	
    65	static struct platform_driver vuport_driver = {
    66		.driver = {
    67			.name = "intel-vuport",
    68			.owner = THIS_MODULE,
    69			.acpi_match_table = ACPI_PTR(vuport_acpi_match),
    70		},
    71		.probe = vuport_probe,
    72		.remove = vuport_remove,
    73	};
    74	
  > 75	module_platform_driver(vuport_driver);
    76	
  > 77	MODULE_AUTHOR("Lu Baolu <baolu.lu@linux.intel.com>");
    78	MODULE_DESCRIPTION("Intel virtual USB port");
    79	MODULE_LICENSE("GPL v2");

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 37405 bytes --]