From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757244AbcCDDMa (ORCPT ); Thu, 3 Mar 2016 22:12:30 -0500 Received: from mail-by2on0091.outbound.protection.outlook.com ([207.46.100.91]:22745 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753256AbcCDDM2 (ORCPT ); Thu, 3 Mar 2016 22:12:28 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O3HVKF-07-IP4-02 X-M-MSG: Date: Fri, 4 Mar 2016 11:11:28 +0800 From: Huang Rui To: Thomas Gleixner CC: Borislav Petkov , Peter Zijlstra , "Ingo Molnar" , Andy Lutomirski , "Robert Richter" , Jacob Shin , "Arnaldo Carvalho de Melo" , Kan Liang , , , , Suravee Suthikulpanit , Aravind Gopalakrishnan , Borislav Petkov , "Fengguang Wu" , Guenter Roeck Subject: Re: [PATCH v6 2/2] perf/x86/amd/power: Add AMD accumulated power reporting mechanism Message-ID: <20160304031127.GB2791@hr-amur2> References: <1456992284-4808-1-git-send-email-ray.huang@amd.com> <1456992284-4808-3-git-send-email-ray.huang@amd.com> <20160303151357.GA2154@hr-amur2> <20160303161809.GA2791@hr-amur2> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(199003)(189002)(24454002)(110136002)(83506001)(4001350100001)(189998001)(586003)(86362001)(77096005)(33656002)(23726003)(106466001)(47776003)(2950100001)(33716001)(93886004)(1220700001)(1076002)(1096002)(105586002)(92566002)(50986999)(5008740100001)(50466002)(87936001)(2906002)(101416001)(46406003)(76176999)(11100500001)(54356999)(81166005)(4326007)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR12MB0850;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 143ff620-0df2-4ee2-2f92-08d343dace52 X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;2:t/LXYzOnkfhC6jcHEBTwtLugARXOcsEUHIOZn5w4xashWXPAwhCsVGUZ3yXSv/JDdkSWJlSgb37woAU+1g6AJwaXde4qUu/j2kdlXYmSmB40pNQyq4zux0k78Vr1rraQn8hNrQ6/pHOqbSHDSixN3mokNpiYDFpPFaIFWYATYCI+EzjKCO5xlf7YZQ+zS6OK;3:P5iiklnviLrfdfYCutPiXcC9l0l6NY4YFqqUfSUiUEoZ0GxoDEe1t9oFMu7QXZSuTAVxR5LX/DVruozS4TlPLR5KUOzdajUz4z/kWUWWSD1Ki0vzilYzrhwRJ8bqHEIVH4m+4qN/MoRjfN+iovvcFguyYhB5V53ZYwzLwsM5KAG0LDwOv6gmJ3GfvKoemc+EZaLFy7QDWh0d5h7sJYaLDbDgXxtrI5c/YGDSLvC8tys=;25:gdqNxT/yJIWeEANvU8Z6k1t1Of7lM73Sg5mNGbri52DkX5UAKA+WS+dtPP5upvGwQkSAn9Hp+mSLVgb7My7mPLJNFh/ahxWXaEFsQZZ3jyDD93VB0aQkq/g+PNhz54Igmz5v0lzp0lxV2MIMVY05dCXahMb7JmRQ7q3uW5Vy+67BMm3tUQSZPmSmYZgd9gugeSxwXU1OqEYp7PZv3bk+gfvQprweAy3NGK7FIybJ2WnkRiXeTKGAqIiQ6pNnQOJjVLLHYhB6vph3McbvhznOlXpsS49LnKMkqTNFZL9YGK9UsC3MIMgEwR9nahsGeV/e+0u1h6mBGH5coS9KYky/EQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0850; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;20:WqQGPGz67nFGnujHNa0NEpcvEWA6IX71SfKdR/hx0Qwr56MGTpSc7neH9bva2uZXzIiip62EKZIx2VQzAGavp4DkctYNu4nz/hROKOY0ioySXU/+Ui1UGl0s12AClqIh7Mgiv8bqoNI70TcSP+ekgkLJeeqTL+UvTt9WuafLe7gY1nsjmfDhbAjBPooYdPU3Rj5jOlttgVTKgC/nHeSmc0dZxx2DUsjscmQ7sZoVT8FHddDgxDq8P719qL36OxS1f7cxZKabZ75yWM+cQi4uLUIfa1nlMUAK6SkqP05w3nQ/lYIZ+qtSoJJ/njry11BbVv+SJ1M5QCIP+B3Gfm4jyJtwJKBtY+mU2OfRoDz0B2YhxkawHXASbpCNcXwWJ+XYE/oivk+88AVO3jhavSb/HU1a9LKUeCX4hKADYOhOWrJjDNRShdXEnNiFGjgocXjruhk6BihMhjKFokeVpEZd0NxXokskrol95BZ+puQ6YFX33kv4FpGYj8K71bl0clod X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(5005006)(8121501046)(13018025)(3002001)(10201501046);SRVR:BN4PR12MB0850;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0850; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;4:22b2QrPOisRuPtavv08bSuXEfVh4JupM6XnutohmA3tLbAttwfTaVNbVPIgvMEF6vOTjtC22FfigAcujJG4xlPcfhTpdxkBSVIBcIbdSiCuM4h43YV8FMTfsop04vCC66+r76tE/zSTofhtHT+kWaoYIsHOPzk6Ea6IY2fxNRm7YxTdhvaWER5/FBUefFrSpi9ovgkxZbfnhzwlMwd93QZG83jL+NQJIUc24cBYVAlHBKUDdkfBIJIY7j83CRmV9QbMcx0s5KaKFwcMUZUhPCt78f//zMaOMPsyaLSELwtY2qGKPbCrvbKjM9lujwi6O9r69mi87LpriEtgvD3qIj14EMu1Gi/KM4T5WMA3VAumTqN1P4VkzkzT8zoHCQPaC9i6WHtgmp6orqanqpiKWQlIqBjtKzvHh5qp6CmXaYXtRNCPKybIARAXJOYcb56IUdD14DcxNt6hg2AIQHpl8yg== X-Forefront-PRVS: 0871917CDA X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN4PR12MB0850;23:+Ay5a9CI6rl+DkQ8zvDtaIOtr5lkXtFBRqrJjgKlR?= =?us-ascii?Q?dnbT8LgRrf1AT4ntprM2vkclu6d74H36Xrzz+rpkS7fzTLiPj5V+RosKi4OE?= =?us-ascii?Q?NgnHLiUk3qsL22VqwepIvi6xz9AUDQBArx1tQhr/q0fZDj4bSuejDmBrkVAX?= =?us-ascii?Q?jjA3SZlMw+pwE1CCrcRU9Sa0ZrHMzfFpFbW7FUX0Qo9r/A8uIsn2GkAX8exW?= =?us-ascii?Q?7DDfvWWODzx5AVY4BVy+WKUDYRHA3LRFfvpO3cxjPntvsdo904gvOB2z7LpL?= =?us-ascii?Q?ab91vIITs3XSM/SHGamnwI6ArIadnh2E4JYqZFYlV9zw13lKIG4FCWx7TVL2?= =?us-ascii?Q?M55P6DyJvn38fg8GFvZdP3lcSjmN3i2V4PnWzmxKM0DWUWUXSH7ftILnG7v+?= =?us-ascii?Q?hy6axyxvCUMtCV6X/3togaRjpjjmqqY5rdUhslgDIAtyOyvRX/NsWeF9XgVt?= =?us-ascii?Q?sdYVXAxXOCTCC7vOO8bI/s3bhesLAPXGhzvwtZQU+jPOPYpkxdFYnnlK8zTX?= =?us-ascii?Q?wIKwQOjMUK0i6Zj836o8+kmr7SaZP9jJyZvKFuI5nfvI9dqqFBeThY5iEiE2?= =?us-ascii?Q?1AmiIhy4FQRXvWpPXNjE2p5sspqxe953s/OMJSCe5+GuKh904MsXD6anb8H7?= =?us-ascii?Q?6NTANjJDa2xdHOALxCvh/yfdRV1scWlAg2hHrRMIhg/5QP/RrvsEF92M6k9O?= =?us-ascii?Q?VrW0PJpDen++KYVMXsOLY3qUutGoF0Yj5FPLIiOcBtkdA2ltQcDf6doIl3ah?= =?us-ascii?Q?74H85QWTbkRkRQpkExxsTIFRQXnYdDvqFL3sUi7nWhto4+KWkQfrxaDlvKcu?= =?us-ascii?Q?OKDSOo5gK4Lq7N9B5oFh1m03cFAX2mgQYaND65WQ4Irz4ZkAnm8nW+OWrPfT?= =?us-ascii?Q?Fzay3GAhshbMrBXSP2RULa7sTKalAJ50BgaKaGb/6lMI+KEyax5qDTwzK+yW?= =?us-ascii?Q?PTqgBzSyt7cnMpoaRGHtkO2n0SHD54L5YGCV+VL6MTC7FZlqez0RCv+mnWD3?= =?us-ascii?Q?N4=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0850;5:C57jC9umK8lbu1B3D/k3u7sOBZARe0Rklej8IZCBQ2E0ulksAcecmjolj6dC1MWyaKLAmelG3lmbQ4KVc0mcmYszP8g/shRmBa2KmpzMXFW+r9CNj4Xk6AB+JylsjrQ1AfD7AZUrTG+vOGt54HDVkQ==;24:D4SbYOujsrgyuq/G2Fn7dyT2ZptIDTxNHf8evqgIBeKYhF2FycO6mv31HaKWmgIJiwIhEQnrYX0TS4I9aE7dWyKrNTupKUF1uKH7H/xtXdc=;20:kVxs1YFyzttTl6AJnqDfUsxzxPhFfHGDOWh7vqu5TCZ/7zXk3H0HIUR4WB/ry6mhAkILCCuJiRLop7h5HN97jwYSdJSml1uZA67bfTAekNrBbVbeax36pc2uZM+wGeJ8cxMjvMOngeu5G6P4ak2RCwEfQp8xUHM5ggeYYGqtNz04rzpiKIAMrTcGGFeTS2U+08p1581ZT6HBZ+XPjzC9mhBJRCCKbHlECF4r/q2kjYrn/kHDmDzEDwmvnNgfoF+w SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2016 03:12:16.9982 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR12MB0850 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2016 at 06:57:53PM +0100, Thomas Gleixner wrote: > On Fri, 4 Mar 2016, Huang Rui wrote: > > On Thu, Mar 03, 2016 at 04:26:46PM +0100, Thomas Gleixner wrote: > > > Why? You do a full for_each_online_cpu(i) loop after that, which does > > > exactly the same thing, right? > > > > > > > But looks like power_cpu_init cannot handle it if we don't take any > > action here. > > > > e. g. > > cpu_mask: 0000 and online mask: 1111 -> power_cpu_init(0) -> cpu_mask is still: 0000 > > > > topology_sibling_cpumask(0): 0011 > > target: 1 (i. e. we cannot do cpumask_set_cpu(0, &cpu_mask)) > > Fair enough, but then you don't need the power_cpu_init() call at all. > > But your loop does not cover anything beyond the first socket. So you need a > separate init function which does: > > for_each_online_cpu(cpu) { > target = cpumask_first(topology_sibling_cpumask(cpu)); > if (!cpumask_test_cpu(target, cpumask)) > cpumask_set_cpu(target, cpumask); > } > Looks good. Thanks Thomas. Will update it. Rui