From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760629AbcCEEZr (ORCPT ); Fri, 4 Mar 2016 23:25:47 -0500 Received: from mail.kernel.org ([198.145.29.136]:47634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760538AbcCEEZp (ORCPT ); Fri, 4 Mar 2016 23:25:45 -0500 Date: Fri, 4 Mar 2016 22:25:36 -0600 From: Rob Herring To: Zhao Qiang Cc: oss@buserror.net, leoyang.li@nxp.com, xiaobo.xie@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings Message-ID: <20160305042536.GD13525@rob-hp-laptop> References: <1456816183-22340-1-git-send-email-qiang.zhao@nxp.com> <1456816183-22340-3-git-send-email-qiang.zhao@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456816183-22340-3-git-send-email-qiang.zhao@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote: > Add uqe_serial document to > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > Signed-off-by: Zhao Qiang > --- > Changes for v2 > - modify tx/rx-clock-name specification > Changes for v2 > - NA > > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > new file mode 100644 > index 0000000..436c71c > --- /dev/null > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > @@ -0,0 +1,19 @@ > +* Serial > + > +Currently defined compatibles: > +- ucc_uart I guess this is in use already and okay. However, looking at the driver there really should be SoC specific compatible strings here since the driver is looking up the SoC compatible string and composing the firmware filename from that. > + > +Properties for ucc_uart: > +port-number : port number of UCC-UART > +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source, > + should be "clk1"-"clk28" for external clock source. > + > +Example: > + > + ucc_serial: ucc@2200 { > + device_type = "serial"; Drop device_type. It should only be used in a few legacy cases. Looks like the driver is matching on this. Please drop it from the driver too. I'd leave dts files for now, but they should be updated too later. > + compatible = "ucc_uart"; > + port-number = <1>; > + rx-clock-name = "brg2"; > + tx-clock-name = "brg2"; > + }; > -- > 2.1.0.27.g96db324 >