From: Rob Herring <robh@kernel.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: broonie@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
lgirdwood@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 RESEND 1/4] regulator: DT: Add DT property for active-discharge configuration
Date: Fri, 4 Mar 2016 22:27:17 -0600 [thread overview]
Message-ID: <20160305042717.GO13525@rob-hp-laptop> (raw)
In-Reply-To: <1456916088-25543-2-git-send-email-ldewangan@nvidia.com>
On Wed, Mar 02, 2016 at 04:24:45PM +0530, Laxman Dewangan wrote:
> Add common DT property for regulator node to support of
> active discharge enable/disable configuration of regulator.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> Changes from V1:
> None
>
> Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++++
> 1 file changed, 5 insertions(+)
Looks okay to me, but for a common property I don't understand what
active discharge means (or why you would want to use it).
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2016-03-05 4:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 10:54 [PATCH V2 RESEND 0/4] regulator: Add support for configuration of active-discharge Laxman Dewangan
2016-03-02 10:54 ` [PATCH V2 RESEND 1/4] regulator: DT: Add DT property for active-discharge configuration Laxman Dewangan
2016-03-05 4:27 ` Rob Herring [this message]
2016-03-02 10:54 ` [PATCH V2 RESEND 2/4] regulator: core: Add support " Laxman Dewangan
2016-03-02 10:54 ` [PATCH V2 RESEND 3/4] regulator: helper: Add helper to configure active-discharge using regmap Laxman Dewangan
2016-03-02 10:54 ` [PATCH V2 RESEND 4/4] regulator: max77620: Add support to configure active-discharge Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305042717.GO13525@rob-hp-laptop \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®