mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Huang, Tao" <huangtao@rock-chips.com>
Cc: Huibin Hong <huibin.hong@rock-chips.com>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	"shawn.lin" <shawn.lin@kernel-upstream.org>,
	linux-rockchip@lists.infradead.org,
	Addy Ke <addy.ke@rock-chips.com>
Subject: Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs
Date: Sat, 5 Mar 2016 13:45:31 +0900	[thread overview]
Message-ID: <20160305044531.GB18327@sirena.org.uk> (raw)
In-Reply-To: <56CFB916.5010403@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

On Fri, Feb 26, 2016 at 10:31:50AM +0800, Huang, Tao wrote:

> You misunderstand me. I talk about spi_setup, as
> Documentation/spi/spi-summary, which would normally be called from
> probe() before the first I/O is done to the device.
> spi_setup will call spi_set_cs(spi, false), which introduced with commit
> 1a7b7ee72c21 ("spi: Ensure that CS line is in non-active state after
> spi_setup()"). And spi_set_cs will call spi->master->set_cs, and set_cs
> callback will access register. Without clk enable, I believe some
> drivers will failed to run.

That's definitely very driver specific, a large proportion of devices
don't manage their chip selects via the SPI controller at all.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

      reply	other threads:[~2016-03-05 12:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 10:00 Huibin Hong
2016-02-24 11:09 ` Huang, Tao
2016-02-26  1:58   ` Mark Brown
2016-02-26  2:31     ` Huang, Tao
2016-03-05  4:45       ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160305044531.GB18327@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=addy.ke@rock-chips.com \
    --cc=huangtao@rock-chips.com \
    --cc=huibin.hong@rock-chips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=shawn.lin@kernel-upstream.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®