From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: davem@davemloft.net, B38611@freescale.com, andrew@lunn.ch,
fabio.estevam@freescale.com, l.stach@pengutronix.de,
rmk+kernel@arm.linux.org.uk, tremyfr@gmail.com,
johannes@sipsolutions.net, haokexin@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] net:fec:Fix error checking in the function fec_enet_init
Date: Sun, 6 Mar 2016 12:09:44 +0100 [thread overview]
Message-ID: <20160306110944.GZ20323@pengutronix.de> (raw)
In-Reply-To: <1457121614-9360-1-git-send-email-xerofoify@gmail.com>
Hello Nicholas,
On Fri, Mar 04, 2016 at 03:00:14PM -0500, Nicholas Krause wrote:
> This fixes error checking in the function fec_enet_init to properly
> check if the internal call to the function fec_enet_alloc_queue fails
> and if so immediately return the error code to the caller for it to
> handle it's own intended error paths.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Looks right. There seem to be some more oportunities for similar
patches. E.g. if dmam_alloc_coherent fails the effects of
fec_enet_alloc_queue should be undone.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2016-03-06 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1457121614-9360-1-git-send-email-xerofoify@gmail.com>
2016-03-06 0:00 ` Fugang Duan
[not found] ` <56DBA8D0.5090906@gmail.com>
2016-03-06 16:10 ` Fugang Duan
2016-03-06 11:09 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306110944.GZ20323@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=B38611@freescale.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=haokexin@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tremyfr@gmail.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®