From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436AbcCFLgB (ORCPT ); Sun, 6 Mar 2016 06:36:01 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37868 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751252AbcCFLfx (ORCPT ); Sun, 6 Mar 2016 06:35:53 -0500 Date: Sun, 6 Mar 2016 18:35:50 +0700 From: Mark Brown To: Laxman Dewangan Cc: linux-kernel@vger.kernel.org Message-ID: <20160306113550.GM18327@sirena.org.uk> References: <20160306023536.GK18327@sirena.org.uk> <56DBE099.9080408@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RiI9WDdlCusJ6wcs" Content-Disposition: inline In-Reply-To: <56DBE099.9080408@nvidia.com> X-Cookie: Adapt. Enjoy. Survive. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 110.170.137.3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: Applied "regulator: max8973: add support for junction thermal warning" to the regulator tree X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --RiI9WDdlCusJ6wcs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 06, 2016 at 01:17:37PM +0530, Laxman Dewangan wrote: > Here driver is built in binary and THERMAL is the loadable module. > Do we really have THERMAL as module i.e. basic framework? If randconfig can generate it it's valid. =20 > -#ifdef CONFIG_THERMAL_OF > +#ifdef CONFIG_THERMAL > static int max8973_thermal_read_temp(void *data, int *temp) > { > struct max8973_chip *mchip =3D data; That looks like a hack that might break, I'd not expect it to help here and probably has some other config that can generate issues. What I think should be happening here is something like depends on THERMAL_OF if THERMAL_OF or similar (ie, there's a direct dependency once the config is enabled). --RiI9WDdlCusJ6wcs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW3BYVAAoJECTWi3JdVIfQlZoH/AiXoI0GgxZ3S0EN1vAFUM3x 2R9LcWhJbGCT2JZZs8RPhQ+CD5/RKHrEJy/OTEyYnZ3i/nlMgxq0j+J3AWBX89IY sK78WY20AKG7HapZWa6bdPtfFtbY85+PtENaWcmbiP2jpJiCDxPno4GUOfzK2ri4 0Jqxq8xqpSsBTV1pLUx0H2sojoRDdcyLtA9+PGXnu6TKmXc/R5201vSkWTPiHZCb ChoyqU61WnpaDklcJVfjPmXUslWZUn2em2yuJhHhjzoHPEgeOTBSNNef2DI0bBAi n3cTzyk2UumayusY59bOu9yNm31zWmTFSzvdXLwvM/OUWe5tNJylZSAmpqizETE= =rJc5 -----END PGP SIGNATURE----- --RiI9WDdlCusJ6wcs--