From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752182AbcCGEKw (ORCPT <rfc822;w@1wt.eu>);
	Sun, 6 Mar 2016 23:10:52 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50564 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751985AbcCGEKp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 6 Mar 2016 23:10:45 -0500
Date: Sun, 6 Mar 2016 22:10:41 -0600
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Miroslav Benes <mbenes@suse.cz>, sjenning@redhat.com, vojtech@suse.com,
        pmladek@suse.cz, mpe@ellerman.id.au, live-patching@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] klp: remove superfluous errors in asm/livepatch.h
Message-ID: <20160307041041.GB11604@treble.hsd1.ky.comcast.net>
References: <1457085219-23653-1-git-send-email-mbenes@suse.cz>
 <20160304214500.GA8104@treble.redhat.com>
 <alpine.LNX.2.00.1603062211300.3656@cbobk.fhfr.pm>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.LNX.2.00.1603062211300.3656@cbobk.fhfr.pm>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 07 Mar 2016 04:10:44 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 06, 2016 at 10:13:56PM +0100, Jiri Kosina wrote:
> On Fri, 4 Mar 2016, Josh Poimboeuf wrote:
> 
> > > There is an #error in asm/livepatch.h for both x86 and s390 in
> > > !CONFIG_LIVEPATCH cases. It does not make much sense as pointed out by
> > > Michael Ellerman. One can happily include asm/livepatch.h with
> > > CONFIG_LIVEPATCH. Remove it as useless.
> > > 
> > > Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> > > Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> > 
> > Looks fine to me.  
> 
> Thanks. I consider this to be your Ack then :) (if you disagree, please 
> shout loudly).

:-)

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

> 
> > While we're at it, do we even need the '#ifdef CONFIG_LIVEPATCH' in 
> > these files?  And in include/linux/livepatch.h?
> 
> You are right, this seems indeed completely unnecessary. I'll remove it 
> for 4.6 as well, if noone has any objections.

-- 
Josh