From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752533AbcCGLns (ORCPT ); Mon, 7 Mar 2016 06:43:48 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:49112 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752202AbcCGLnl (ORCPT ); Mon, 7 Mar 2016 06:43:41 -0500 Date: Mon, 7 Mar 2016 11:41:16 +0000 From: One Thousand Gnomes To: Zhen Lei Cc: Andrew Morton , Marek Szyprowski , Will Deacon , linux-kernel , Zefan Li , Xinwei Hu , "Tianhong Ding" , Hanjun Guo Subject: Re: [PATCH 1/1] dma-mapping: to avoid exception when cpu_addr is NULL Message-ID: <20160307114116.54160865@lxorguk.ukuu.org.uk> In-Reply-To: <1457342485-16628-1-git-send-email-thunder.leizhen@huawei.com> References: <1457342485-16628-1-git-send-email-thunder.leizhen@huawei.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Mar 2016 17:21:25 +0800 Zhen Lei wrote: > Do this to keep consistent with kfree, which tolerate ptr is NULL. > > Signed-off-by: Zhen Lei This is inlined code so you are adding extra logic to every single instance of a call to the function. What is it's total effect on kernel size ? Alan