From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933111AbcCIPwr (ORCPT ); Wed, 9 Mar 2016 10:52:47 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35168 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933044AbcCIPwl (ORCPT ); Wed, 9 Mar 2016 10:52:41 -0500 Date: Wed, 9 Mar 2016 16:52:38 +0100 From: Michal Hocko To: Vlastimil Babka Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Andrea Arcangeli , "Kirill A. Shutemov" , Rik van Riel , Joonsoo Kim , Mel Gorman , David Rientjes , Johannes Weiner Subject: Re: [PATCH v2 0/5] introduce kcompactd and stop compacting in kswapd Message-ID: <20160309155238.GK27018@dhcp22.suse.cz> References: <1454938691-2197-1-git-send-email-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454938691-2197-1-git-send-email-vbabka@suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 08-02-16 14:38:06, Vlastimil Babka wrote: > The previous RFC is here [1]. It didn't have a cover letter, so the description > and results are in the individual patches. FWIW I think this is a step in the right direction. I would give my Acked-by to all patches but I wasn't able to find time for a deep review and my lack of knowledge of compaction details doesn't help much. I do agree that conflating kswapd with compaction didn't really work out well and fixing this would just make the code more complex and would more prone to new bugs. In future we might want to invent something similar to watermarks and set an expected level of high order pages prepared for the allocation (e.g. have at least XMB of memory in order-9+). kcompact then could try as hard as possible to provide them. Does that sound at least doable? Thanks! -- Michal Hocko SUSE Labs