From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934911AbcCJDLl (ORCPT ); Wed, 9 Mar 2016 22:11:41 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48732 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754349AbcCJDLf (ORCPT ); Wed, 9 Mar 2016 22:11:35 -0500 Date: Thu, 10 Mar 2016 10:10:12 +0700 From: Mark Brown To: Mihai Mihalache Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com, hans.holmberg@intel.com, yousaf.kaukab@intel.com Message-ID: <20160310031012.GH3898@sirena.org.uk> References: <1457531442-4695-1-git-send-email-mihai.d.mihalache@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nFBW6CQlri5Qm8JQ" Content-Disposition: inline In-Reply-To: <1457531442-4695-1-git-send-email-mihai.d.mihalache@intel.com> X-Cookie: Do not flush. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 110.170.137.3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: gpio: check return value of of_get_named_gpio X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nFBW6CQlri5Qm8JQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 09, 2016 at 05:50:42AM -0800, Mihai Mihalache wrote: > config->enable_gpio = of_get_named_gpio(np, "enable-gpio", 0); > + if(IS_ERR_VALUE(config->enable_gpio)) > + return ERR_PTR(config->enable_gpio); Please follow the kernel coding style - if(. --nFBW6CQlri5Qm8JQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW4OWQAAoJECTWi3JdVIfQM3gH/RFlJHd8Qx4hfcc5C1HzcRUH cjcj4fMlo96PtIQ2ZSRVHHFPnDcciuwtsi2UARHRzZxPXx6z0pL9pfGG1Ib9RUok G7fzk6Oyc9QIFK4aPzRqy2zNPCtmdNM92O/t00iE3XbGLbBkTcjlswAIkzcwbCkP xpT7ZJF9molxEsIzg+WMnVksPlxhaA2qfacD5V3lRDPjdh17qv5kploBKdrdZ61p zLHFn7goyK12FLi9tL2ZU9olIZSbtXE70mwtotg+/qGszE2jvJDacUUvb/1CsPJz z4kkJUxZFpgVSeDt/ZTcYkv83qfkRrjeF81bJ4MDzUeP+wksHItj9RQiwtESWdQ= =iny1 -----END PGP SIGNATURE----- --nFBW6CQlri5Qm8JQ--