From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S935249AbcCJKAV (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Mar 2016 05:00:21 -0500
Received: from mx2.suse.de ([195.135.220.15]:53799 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933050AbcCJKAP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Mar 2016 05:00:15 -0500
Date: Thu, 10 Mar 2016 11:00:12 +0100
From: Petr Mladek <pmladek@suse.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
        John Stultz <john.stultz@linaro.org>,
        Xunlei Pang <pang.xunlei@linaro.org>,
        Baolin Wang <baolin.wang@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tejun Heo <tj@kernel.org>, Peter Hurley <peter@hurleysoftware.com>,
        Vasily Averin <vvs@virtuozzo.com>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH 0/2 v6] printk, Add monotonic and real printk timestamps
Message-ID: <20160310100012.GQ10940@pathway.suse.cz>
References: <1456250040-22351-1-git-send-email-prarit@redhat.com>
 <alpine.DEB.2.11.1603080858570.3859@nanos>
 <56DEB17C.9000201@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56DEB17C.9000201@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue 2016-03-08 06:03:24, Prarit Bhargava wrote:
> 
> 
> On 03/08/2016 02:59 AM, Thomas Gleixner wrote:
> > On Tue, 23 Feb 2016, Prarit Bhargava wrote:
> > 
> >> This patchset adds monotonic and real printk timestamps.  The first patch
> >> changes CONFIG_PRINT_TIME from a bool to an int to allow for the additional
> >> timestamps that are added in patch 2.
> >>
> >> Changes from v6: Petr Mladek pointed out that the current patch
> >> fails to indicate to userspace programs which timestamp is being used.
> > 
> > How is that solved?
> 
> Hi Thomas,
> 
> Userspace programs can now look at /sys/modules/printk/parameters/time which
> will contain [0-3] for the timestamp clock.

But it includes only the current setting that is valid only for
messages printed with this setting. The ring buffer might include
different messages produced with different setting.

I suggest to look how dmesg handles the time stamp. I wonder how it
converts the relative time into an absolute one. I wonder if you
could convert all timestamps to the relative format, so that you
do not need to change all userspace tools at all.

Best regards,
Petr