From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751326AbcCKSFJ (ORCPT ); Fri, 11 Mar 2016 13:05:09 -0500 Received: from www.linutronix.de ([62.245.132.108]:38981 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbcCKSFG (ORCPT ); Fri, 11 Mar 2016 13:05:06 -0500 Date: Fri, 11 Mar 2016 19:05:04 +0100 From: Sebastian Andrzej Siewior To: tglx@linutronix.de, rostedt@goodmis.org Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: [RFC RT] tty: serial: 8250: don't take the lock on OOPs Message-ID: <20160311180504.GB29850@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Key-Id: 2A8CF5D1 X-Key-Fingerprint: 6425 4695 FFF0 AA44 66CC 19E6 7B96 E816 2A8C F5D1 User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On panic() from IRQ (for instance from the lockup detector) we will end up in an endless loop on -RT. Each time we invoke spin_trylock_irqsave() we will trigger the WARN_ON() in rt_mutex_trylock(). The WARN_ON() will stuff more data into the printk buffer than we can print on one iteration and so we never end the printing loop. Signed-off-by: Sebastian Andrzej Siewior --- drivers/tty/serial/8250/8250_port.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c index 5568d70eee0c..138b1b985063 100644 --- a/drivers/tty/serial/8250/8250_port.c +++ b/drivers/tty/serial/8250/8250_port.c @@ -2850,9 +2850,9 @@ void serial8250_console_write(struct uart_8250_port *up, const char *s, serial8250_rpm_get(up); - if (port->sysrq) + if (port->sysrq || oops_in_progress) locked = 0; - else if (oops_in_progress || in_kdb_printk()) + else if (in_kdb_printk()) locked = spin_trylock_irqsave(&port->lock, flags); else spin_lock_irqsave(&port->lock, flags); -- 2.7.0