From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932998AbcCKWUn (ORCPT ); Fri, 11 Mar 2016 17:20:43 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:59015 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932084AbcCKWUk (ORCPT ); Fri, 11 Mar 2016 17:20:40 -0500 Date: Fri, 11 Mar 2016 14:20:39 -0800 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [RFC PATCH 1/3] siox: new driver/bus framework for Eckelmann SIOX Message-ID: <20160311222039.GC3912@kroah.com> References: <1457733134-25090-1-git-send-email-u.kleine-koenig@pengutronix.de> <1457733134-25090-2-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1457733134-25090-2-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 11, 2016 at 10:52:12PM +0100, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König > --- > drivers/Kconfig | 2 + > drivers/Makefile | 1 + > drivers/siox/Kconfig | 2 + > drivers/siox/Makefile | 1 + > drivers/siox/siox-core.c | 572 +++++++++++++++++++++++++++++++++++++++++++++++ > drivers/siox/siox.h | 48 ++++ > include/linux/siox.h | 53 +++++ > 7 files changed, 679 insertions(+) > create mode 100644 drivers/siox/Kconfig > create mode 100644 drivers/siox/Makefile > create mode 100644 drivers/siox/siox-core.c > create mode 100644 drivers/siox/siox.h > create mode 100644 include/linux/siox.h What's the relationship between your "master" and "regular" devices here? I think that's getting things confused, you are unregistering your 'master' yet the children it controls don't go away because you never unregister them. You need to fix this heirachy up a bit, and maybe just drop the 'master' logic? thanks, greg k-h