From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754014AbcCMIeW (ORCPT ); Sun, 13 Mar 2016 04:34:22 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56590 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752838AbcCMIeV (ORCPT ); Sun, 13 Mar 2016 04:34:21 -0400 Date: Sat, 12 Mar 2016 13:05:43 +0700 From: Mark Brown To: Laxman Dewangan Cc: robh+dt@kernel.org, pawel.moll@arm.com, lgirdwood@gmail.com, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20160312060543.GV3898@sirena.org.uk> References: <1457434405-30372-1-git-send-email-ldewangan@nvidia.com> <1457434405-30372-4-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s0H35NU0PUc8VBh+" Content-Disposition: inline In-Reply-To: <1457434405-30372-4-git-send-email-ldewangan@nvidia.com> X-Cookie: Do not flush. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/5] regulator: pwm: Prints error number when it fails X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --s0H35NU0PUc8VBh+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 08, 2016 at 04:23:23PM +0530, Laxman Dewangan wrote: > + dev_err(&pdev->dev, "Failed to get PWM, %d\n", ret); Pretty much everywhere else in the kernel we use "foo: %d\n" - please use a consistent style. --s0H35NU0PUc8VBh+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW47G2AAoJECTWi3JdVIfQb9wH/3lCklezgp8xJHR10yCODkkm oECex912AuYw7vYeCOap4AAscFdzhjh0dpZCWBXtH3tEC5Tkf7I0iTpQAmJKpEos usAGvlSezhQwkgo8BqemMfLLaIfj43r1pI0E+RICupBZPKZJJ6WdVZFTp3/TrBkC asmsrSdN+ZQsxeCzot4yZrOBptymma4YM6BNIIkVZ0+OppnCw1t6CRyC1dGS06ry khmYJBObIsLXlFRtkoABUSgEBXyJDYYanszg0Tw05R1B3eUe8Lqnzk8HUEUHB3WO CF8DlVW4IFBoxsnmzLT22zsUeY1QT7eNGgkppbt1vml+dIhcHQkly6JYwgoYNaw= =Dteo -----END PGP SIGNATURE----- --s0H35NU0PUc8VBh+--