mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC][PATCH] perf config: Introduce perf_config_set class
Date: Sat, 12 Mar 2016 17:45:41 +0900	[thread overview]
Message-ID: <20160312084541.GB27257@danjae.kornet> (raw)
In-Reply-To: <56E2DF84.7080406@gmail.com>

Hi Taeung,

On Sat, Mar 12, 2016 at 12:08:52AM +0900, Taeung Song wrote:
> Hi, Namhyung
> 
> On 03/11/2016 11:11 PM, Namhyung Kim wrote:
> >Also I think it'd be better just keeping a single config value instead
> >of 3 kinds.  Maybe you can read system-wide config first and overwrite
> >them with user config (for the 'both' case).
> >
> 
> I know what you mean. I agonized about it.
> 
> IMHO, I think that if keeping a single config value instead of 3 kinds and
> perf-config has setting functionality when writing a changed config
> on a specific config file, some problems can occur e.g.

Do you plan to support 'set' and 'get' operation at the same time?
IOW is it possible to do?

  $ perf config --set aaa.bbb=xx --get ccc.ddd

I don't think it's very useful.

If we don't do it, I think we can simply read a single config file
(default to user file) and re-write it for the 'set' operation.

Or maybe we can add a field (like 'origin'?) in the perf_config_item
struct to mark where it comes from.  And then it should write items
matching 'origin' only.

Thanks,
Namhyung


> 
> (Because setting functionality I design is that overwrite
> a specific config file by the perf config list)
> (the perf config list : all perf configs from the config files)
> 
> User wide:
> 
>     # cat ~/.perfconfig
>     [report]
>         queue-size = 1
>     [test]
>         location = user
> 
> System wide:
> 
>     # cat /usr/local/etc/perfconfig
>     [ui]
>         show-headers = false
>     [test]
>         location = system
> 
> And if perf-config has setting functionality,
> 
>     # perf config --system top.children=false
> 
> We hoped for:
> 
>     # cat /usr/local/etc/perfconfig
>     [ui]
>         show-headers = false
>     [test]
>         location = system
>     [top]
>         children = false
> 
> But actual result can be:
> 
>     # cat /usr/local/etc/perfconfig
>     [ui]
>         show-headers = false
>     [report]
>         queue-size = 1
>     [test]
>         location = user
>     [top]
>         children = false
> 
> We wouldn't want that system config file contain contents of
> user config file.
> The reason of this problem is that setting functionality I design
> work with perf config list overwriting a specific config file
> and if perf config list has only single value each config,
> we don't exactly know old values of system config.
> 
> Don't design setting functionality that overwrite by perf config list ?
> (writing '# this file is auto-generated.' at the top of config file)
> 
> Add a changed config into a specific config file by other way ? :-\
> 
> Or
> Not now, when add setting functionality into perf-config,
> consider this problem ?
> 
> Thanks,
> Taeung

  reply	other threads:[~2016-03-12  8:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10 14:04 Taeung Song
2016-03-11 14:11 ` Namhyung Kim
2016-03-11 15:08   ` Taeung Song
2016-03-12  8:45     ` Namhyung Kim [this message]
2016-03-12 10:28       ` Taeung Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160312084541.GB27257@danjae.kornet \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=treeze.taeung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®