From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754326AbcCNCUY (ORCPT ); Sun, 13 Mar 2016 22:20:24 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:40486 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbcCNCUQ (ORCPT ); Sun, 13 Mar 2016 22:20:16 -0400 Date: Sun, 13 Mar 2016 22:20:11 -0400 (EDT) Message-Id: <20160313.222011.1724698990540701829.davem@davemloft.net> To: nicolas.ferre@atmel.com Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, cyrille.pitchen@atmel.com, linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, boris.brezillon@free-electrons.com, romain.henriet@l-acoustics.com, michal.simek@xilinx.com, punnaia@xilinx.com Subject: Re: [PATCH] net: macb: fix default configuration for GMAC on AT91 From: David Miller In-Reply-To: <1457624672-30666-1-git-send-email-nicolas.ferre@atmel.com> References: <1457624672-30666-1-git-send-email-nicolas.ferre@atmel.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 13 Mar 2016 19:20:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicolas Ferre Date: Thu, 10 Mar 2016 16:44:32 +0100 > On AT91 SoCs, the User Register (USRIO) exposes a switch to configure the > "Reduced" or "Traditional" version of the Media Independent Interface > (RMII vs. MII or RGMII vs. GMII). > As on the older EMAC version, on GMAC, this switch is set by default to the > non-reduced type of interface, so use the existing capability and extend it to > GMII as well. We then keep the current logic in the macb_init() function. > > The capabilities of sama5d2, sama5d4 and sama5d3 GEM interface are updated in > the macb_config structure to be able to properly enable them with a traditional > interface (GMII or MII). > > Reported-by: Romain HENRIET > Signed-off-by: Nicolas Ferre Applied.