mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nicolas Saenz Julienne <nicolassaenzj@gmail.com>
Cc: oliver@neukum.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930
Date: Sat, 12 Mar 2016 16:27:29 -0800	[thread overview]
Message-ID: <20160313002729.GA4420@kroah.com> (raw)
In-Reply-To: <1457826291-5204-1-git-send-email-nicolassaenzj@gmail.com>

On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote:
> Signed-off-by: Nicolas Saenz Julienne <nicolassaenzj@gmail.com>
> ---
>  drivers/usb/class/cdc-acm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index fa4e239..9831607 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = {
>  	{ USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */
>  	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
>  	},
> +	{ USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */
> +	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> +	},

Why is this needed?  Does the descriptors not properly set the class
device?

thanks,

greg k-h

  parent reply	other threads:[~2016-03-13  0:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-12 23:44 Nicolas Saenz Julienne
2016-03-13  0:11 ` YU Bo
2016-03-13  0:27 ` Greg KH [this message]
2016-03-15  0:04   ` Nicolas Saenz Julienne
2016-03-15  8:48     ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160313002729.GA4420@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nicolassaenzj@gmail.com \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome