From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753916AbcCMC5M (ORCPT ); Sat, 12 Mar 2016 21:57:12 -0500 Received: from imap.thunk.org ([74.207.234.97]:37460 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751304AbcCMC5K (ORCPT ); Sat, 12 Mar 2016 21:57:10 -0500 Date: Sat, 12 Mar 2016 21:57:05 -0500 From: "Theodore Ts'o" To: Ales Novak Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix: print ext4 mountopt data_err=abort correctly Message-ID: <20160313025705.GB29218@thunk.org> Mail-Followup-To: Theodore Ts'o , Ales Novak , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <1457528979-25737-1-git-send-email-alnovak@suse.cz> <1457548240-30948-1-git-send-email-alnovak@suse.cz> <1457548240-30948-2-git-send-email-alnovak@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457548240-30948-2-git-send-email-alnovak@suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2016 at 07:30:40PM +0100, Ales Novak wrote: > If data_err=abort option is specified for an ext3/ext4 mount, > /proc/mounts does show it as "(null)". This is caused by token2str() > returning NULL for Opt_data_err_abort (due to its pattern containing > '='). > > This is perhaps more logical solution than the previously submitted, > handling these 'data_err=' options in other way than MOPT_SET. > > Signed-off-by: Ales Novak Thanks, applied. - Ted