From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932686AbcCNXhX (ORCPT ); Mon, 14 Mar 2016 19:37:23 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:50970 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbcCNXhV (ORCPT ); Mon, 14 Mar 2016 19:37:21 -0400 Date: Mon, 14 Mar 2016 19:37:16 -0400 (EDT) Message-Id: <20160314.193716.2139468785282657178.davem@davemloft.net> To: arnd@arndb.de Cc: nico@fluxnic.net, robert.jarzmik@free.fr, u.kleine-koenig@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] smc91x: avoid self-comparison warning From: David Miller In-Reply-To: <1457995535-1398186-1-git-send-email-arnd@arndb.de> References: <1457995535-1398186-1-git-send-email-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 14 Mar 2016 16:37:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 14 Mar 2016 23:45:12 +0100 > The smc91x driver defines a macro that compares its argument to > itself, apparently to get a true result while using its argument > to avoid a warning about unused local variables. > > Unfortunately, this triggers a warning with gcc-6, as the comparison > is obviously useless: > > drivers/net/ethernet/smsc/smc91x.c: In function 'smc_hardware_send_pkt': > drivers/net/ethernet/smsc/smc91x.c:563:14: error: self-comparison always evaluates to true [-Werror=tautological-compare] > if (!smc_special_trylock(&lp->lock, flags)) { > > This replaces the macro with another one that behaves similarly, > with a cast to (void) to ensure the argument is used, and using > a literal 'true' as its value. > > Signed-off-by: Arnd Bergmann Applied, thanks.