From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933883AbcCNIPP (ORCPT ); Mon, 14 Mar 2016 04:15:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:58546 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933837AbcCNIPD (ORCPT ); Mon, 14 Mar 2016 04:15:03 -0400 Date: Mon, 14 Mar 2016 09:15:00 +0100 From: Johannes Thumshirn To: Dan Williams Cc: axboe@fb.com, James Bottomley , Ulf Hansson , "Martin K. Petersen" , Konrad Rzeszutek Wilk , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, hch@lst.de, Keith Busch , linux-block@vger.kernel.org, Ross Zwisler , David Woodhouse , "David S. Miller" Subject: Re: [PATCH v2 2/3] block: convert to device_add_disk() Message-ID: <20160314081500.GQ16624@c203.arch.suse.de> References: <20160311154727.24401.87967.stgit@dwillia2-desk3.jf.intel.com> <20160311154738.24401.867.stgit@dwillia2-desk3.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160311154738.24401.867.stgit@dwillia2-desk3.jf.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 11, 2016 at 07:47:38AM -0800, Dan Williams wrote: > For block drivers that specify a parent device, convert them to use > device_add_disk(). > > This conversion was done with the following semantic patch: > > @@ > struct gendisk *disk; > expression E; > @@ > > - disk->driverfs_dev = E; > ... > - add_disk(disk); > + device_add_disk(E, disk); > > @@ > struct gendisk *disk; > expression E1, E2; > @@ > > - disk->driverfs_dev = E1; > ... > E2 = disk; > ... > - add_disk(E2); > + device_add_disk(E1, E2); > > ...plus some manual fixups for a few missed conversions. > > Cc: Jens Axboe > Cc: Christoph Hellwig > Cc: Keith Busch > Cc: Michael S. Tsirkin > Cc: Ulf Hansson > Cc: David Woodhouse > Cc: David S. Miller > Cc: James Bottomley > Cc: Ross Zwisler > Cc: Konrad Rzeszutek Wilk > Cc: Martin K. Petersen > Signed-off-by: Dan Williams Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850