From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934278AbcCPC5P (ORCPT ); Tue, 15 Mar 2016 22:57:15 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38053 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480AbcCPC5O (ORCPT ); Tue, 15 Mar 2016 22:57:14 -0400 Date: Tue, 15 Mar 2016 22:57:09 -0400 (EDT) Message-Id: <20160315.225709.1732687324535302348.davem@davemloft.net> To: robert.jarzmik@free.fr Cc: festevam@gmail.com, g.liakhovetski@gmx.de, mitake@dcl.info.waseda.ac.jp, fabio.estevam@freescale.com, mitake.hitoshi@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: smc911x: convert pxa dma to dmaengine From: David Miller In-Reply-To: <87wpp3mjt1.fsf@belgarion.home> References: <87lh5zpbaw.fsf@belgarion.home> <87wpp3mjt1.fsf@belgarion.home> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 15 Mar 2016 19:57:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Robert Jarzmik Date: Tue, 15 Mar 2016 23:56:58 +0100 > Robert Jarzmik writes: > >> Fabio Estevam writes: >>> Tested-by: Fabio Estevam >> >> Thanks Fabio for the test. >> >> I also tried with a different different approach. >> >> I built the different platforms (imx v6, etc ...) : >> - one version (a) on a vanilla v4.5-rc2 >> - one version (b) on a vaniall v4.5-rc2 + this patch >> >> For each of the builds, I took the preprocessed output of smc911x.c, and made a >> diff between (a) and (b). The commands used were : >> - building in [1] >> - diffing in [2] >> >> The result is [3]. I conclude from [3] that the driver cannot break for non PXA >> platforms. >> >> With Fabio's test and this demonstration, is enough to convince you to apply >> this patch David ? > Hi David, > > Can you consider this patch now it is tested please ? Please resubmit the patch fresh with the appropriate Tested-by: tags added, thanks.