From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934816AbcCOQj6 (ORCPT ); Tue, 15 Mar 2016 12:39:58 -0400 Received: from mga14.intel.com ([192.55.52.115]:41863 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbcCOQj5 (ORCPT ); Tue, 15 Mar 2016 12:39:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,340,1455004800"; d="scan'208";a="937670805" Date: Tue, 15 Mar 2016 09:39:56 -0700 From: Andi Kleen To: Dave Jones , x86@kernel.org, Linux Kernel Subject: Re: Fix suspicious RCU usage in msr tracing. Message-ID: <20160315163956.GQ23621@tassilo.jf.intel.com> References: <20160315012054.GA17765@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160315012054.GA17765@codemonkey.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Back in January, Andi suggested swapping the order in which > we ack the APIC irq, so it too is protected by rcu. > There was no follow-up, and it seems to work for me. > > Cc: Andi Kleen Reviewed-by: Andi Kleen -Andi > Signed-off-by: Dave Jones > > diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h > index c80f6b6f3da2..e8c4fba52d3d 100644 > --- a/arch/x86/include/asm/apic.h > +++ b/arch/x86/include/asm/apic.h > @@ -644,8 +644,8 @@ static inline void entering_irq(void) > > static inline void entering_ack_irq(void) > { > - ack_APIC_irq(); > entering_irq(); > + ack_APIC_irq(); > } > > static inline void ipi_entering_ack_irq(void) -- ak@linux.intel.com -- Speaking for myself only