From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756423AbcCQBfk (ORCPT ); Wed, 16 Mar 2016 21:35:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51878 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756364AbcCQBfS (ORCPT ); Wed, 16 Mar 2016 21:35:18 -0400 Date: Wed, 16 Mar 2016 18:35:13 -0700 From: Greg KH To: "Gavin O'Leary" Cc: david.kershner@unisys.com, benjamin.romer@unisys.com, timothy.sell@unisys.com, nhorman@redhat.com, sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: unisys: visornic: Fixed Checkpatch Warnings Message-ID: <20160317013513.GA14065@kroah.com> References: <1458177887-4779-1-git-send-email-gavinoleary3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458177887-4779-1-git-send-email-gavinoleary3@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 16, 2016 at 06:24:47PM -0700, Gavin O'Leary wrote: > Fixed the coding style checkpatch warnings. Which ones? Always be specific. And only fix one type of thing at a time. > > Signed-off-by: Gavin O'Leary > --- > drivers/staging/unisys/visornic/visornic_main.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c > index 0519470..0366624 100644 > --- a/drivers/staging/unisys/visornic/visornic_main.c > +++ b/drivers/staging/unisys/visornic/visornic_main.c > @@ -1218,8 +1218,9 @@ visornic_rx(struct uiscmdrsp *cmdrsp) > /* length rcvd is greater than firstfrag in this skb rcv buf */ > skb->tail += RCVPOST_BUF_SIZE; /* amount in skb->data */ > skb->data_len = skb->len - RCVPOST_BUF_SIZE; /* amount that > - will be in > - frag_list */ > + * will be in > + * frag_list > + */ Tell me that looks better :( Please fix this properly. thanks, greg k-h