From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756244AbcCQCGy (ORCPT ); Wed, 16 Mar 2016 22:06:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52798 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752914AbcCQCGx (ORCPT ); Wed, 16 Mar 2016 22:06:53 -0400 Date: Wed, 16 Mar 2016 19:06:50 -0700 From: Greg KH To: "Gavin O'Leary" Cc: david.kershner@unisys.com, benjamin.romer@unisys.com, sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: unisys: visornic: Fixed block comment coding style warnings Message-ID: <20160317020650.GA18660@kroah.com> References: <1458180111-6403-1-git-send-email-gavinoleary3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458180111-6403-1-git-send-email-gavinoleary3@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 16, 2016 at 07:01:51PM -0700, Gavin O'Leary wrote: > Fixed block comment checkpatch warnings. > > Signed-off-by: Gavin O'Leary > --- > drivers/staging/unisys/visornic/visornic_main.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c > index 0519470..eefbacc 100644 > --- a/drivers/staging/unisys/visornic/visornic_main.c > +++ b/drivers/staging/unisys/visornic/visornic_main.c > @@ -1315,12 +1315,14 @@ visornic_rx(struct uiscmdrsp *cmdrsp) > } > if (found_mc) > break; /* accept packet, dest > - matches a multicast > - address */ > + * matches a multicast > + * address > + */ That looks horrible, don't you think? > } > } else if (skb->pkt_type == PACKET_HOST) { > break; /* accept packet, h_dest must match vnic > - mac address */ > + * mac address > + */ Same here. Please fix up to look better, that's your goal, right? thanks, greg k-h