From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933972AbcCRO1y (ORCPT ); Fri, 18 Mar 2016 10:27:54 -0400 Received: from smtprelay0127.hostedemail.com ([216.40.44.127]:59230 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933407AbcCRO1v (ORCPT ); Fri, 18 Mar 2016 10:27:51 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3870:3872:3874:3876:4321:4605:5007:6261:7875:10004:10400:10848:10967:11232:11658:11914:12296:12517:12519:12555:12740:13069:13311:13357:13439:14096:14097:14659:14721:21080:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: feet68_27182c5c73158 X-Filterd-Recvd-Size: 1932 Date: Fri, 18 Mar 2016 10:27:47 -0400 From: Steven Rostedt To: Jiri Olsa Cc: lkml , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling events Message-ID: <20160318102747.25d17fa5@gandalf.local.home> In-Reply-To: <1458138873-1553-2-git-send-email-jolsa@kernel.org> References: <1458138873-1553-1-git-send-email-jolsa@kernel.org> <1458138873-1553-2-git-send-email-jolsa@kernel.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Mar 2016 15:34:29 +0100 Jiri Olsa wrote: > Currently we check sample type for ftrace:function event > even if it's not created as sampling event. That prevents > creating ftrace_function event in counting mode. > > Making sure we check sample types only for sampling events. > > Before: > $ sudo perf stat -e ftrace:function ls > ... > > Performance counter stats for 'ls': > > ftrace:function > > 0.001983662 seconds time elapsed > > After: > $ sudo perf stat -e ftrace:function ls > ... > > Performance counter stats for 'ls': > > 44,498 ftrace:function > > 0.037534722 seconds time elapsed > > Suggested-by: Namhyung Kim > Signed-off-by: Jiri Olsa Acked-by: Steven Rostedt -- Steve