From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757395AbcCRO2v (ORCPT ); Fri, 18 Mar 2016 10:28:51 -0400 Received: from smtprelay0106.hostedemail.com ([216.40.44.106]:55755 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751042AbcCRO2r (ORCPT ); Fri, 18 Mar 2016 10:28:47 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 57,3.5,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2907:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3874:5007:6261:7875:7903:10013:10400:10848:10967:11232:11658:11914:12296:12517:12519:12740:13069:13311:13357:13439:13972:14096:14097:14659:14721:21080:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:2:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: love29_2f654ce2efc28 X-Filterd-Recvd-Size: 2175 Date: Fri, 18 Mar 2016 10:28:44 -0400 From: Steven Rostedt To: Jiri Olsa Cc: lkml , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: Re: [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer Message-ID: <20160318102844.4b59686a@gandalf.local.home> In-Reply-To: <1458138873-1553-4-git-send-email-jolsa@kernel.org> References: <1458138873-1553-1-git-send-email-jolsa@kernel.org> <1458138873-1553-4-git-send-email-jolsa@kernel.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Mar 2016 15:34:31 +0100 Jiri Olsa wrote: > Having following commands running concurrently: > > # perf record -e ftrace:function -a -o krava.data sleep 10 > # perf record -e ftrace:function --filter 'ip == SyS_read' ls > > will end up in the latter one to fail on the filter rules > and store all functions (in perf.data) as instructed by the > first perf record instead of just SyS_read records. > > The reason for this is, that tracepoint code by default > triggers all events that registered for the tracepoint. > > While ftrace:function is special because ftrace_ops > itself carries a filter and only the event that owns > ftrace_ops is eligible to be triggered. > > Fixing this by using ftrace_ops::private value to keep > the perf_event pointer. This way we don't need to search > for triggered event (as tracepoint handler does) and > directly store sample. > > Acked-by: Namhyung Kim > Suggested-by: Steven Rostedt > Signed-off-by: Jiri Olsa Acked-by: Steven Rostedt -- Steve