From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932709AbcCRVos (ORCPT ); Fri, 18 Mar 2016 17:44:48 -0400 Received: from mail.kernel.org ([198.145.29.136]:58831 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932609AbcCRVoo (ORCPT ); Fri, 18 Mar 2016 17:44:44 -0400 Date: Fri, 18 Mar 2016 16:44:39 -0500 From: Rob Herring To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, Jiang Liu , devicetree@vger.kernel.org Subject: Re: [PATCH v2] x86: dts: ce4100: Use defined compatible string for PCF8575 chip Message-ID: <20160318214439.GA17481@rob-hp-laptop> References: <1458147080.20441.1.camel@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458147080.20441.1.camel@codethink.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 16, 2016 at 04:51:20PM +0000, Ben Hutchings wrote: > The binding definition for the PCF857x GPIO expanders doesn't mention > a "ti,pcf8575" compatible string. This is apparently because TI is > only a second source - there is no functional difference between > PCF8575 chips manufactured by TI and NXP, and the same board might be > populated with either depending on availability. > > This is not a problem in practice because the I2C core uses > of_modalias_node() before matching drivers and this strips the > manufacturer name. > > Signed-off-by: Ben Hutchings > --- > v2: Correct the claim that this is a practical problem. > > Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt | 4 ++-- > arch/x86/platform/ce4100/falconfalls.dts | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Acked-by: Rob Herring