From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753883AbcCUJSE (ORCPT ); Mon, 21 Mar 2016 05:18:04 -0400 Received: from mail-bl2on0078.outbound.protection.outlook.com ([65.55.169.78]:53104 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751842AbcCUJRy (ORCPT ); Mon, 21 Mar 2016 05:17:54 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O4DTTL-07-DSS-02 X-M-MSG: Date: Mon, 21 Mar 2016 17:18:06 +0800 From: Huang Rui To: Borislav Petkov CC: Sherry Hurwitz , Peter Zijlstra , , , , , , "Gang Long" , Subject: Re: [PATCH 2/3] x86/topology: Fix AMD core count Message-ID: <20160321091804.GA26555@hr-amur2> References: <20160318150345.146716865@infradead.org> <20160318150538.551407299@infradead.org> <20160318164101.GG7817@pd.tnic> <20160321030744.GA26269@hr-amur2> <20160321034618.GB26269@hr-amur2> <20160321082643.GB15904@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160321082643.GB15904@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(164054003)(24454002)(189002)(199003)(23726003)(87936001)(1076002)(1220700001)(1096002)(5008740100001)(11100500001)(2950100001)(97756001)(46406003)(586003)(86362001)(33716001)(110136002)(189998001)(47776003)(106466001)(105586002)(50466002)(76176999)(81166005)(92566002)(54356999)(93886004)(101416001)(4001350100001)(77096005)(33656002)(50986999)(83506001)(19580405001)(2906002)(107986001)(473944003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0855;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 604f5055-1b46-49a6-ab07-08d35169ad23 X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0855;2:o6ftkJWIRrsLAMOy43JdKgqdmV/ACQf4iJQh1qti4REZTusXGmW6g92ZZMM53Q5LGGGm99toBjt52zXHR+BWO66zF0ses/uax43rQxboYDwgYjnv2GMYGlWmmWsIOaFC1k05yrEkyWWRt3DuIunr1vRqmb0PRAeQD+UsXBYhT11NECHH8k2AW2TKZ+Tesfg5;3:urDWCy3966JiVynLbqINUj3naWibZVwmnhMZGxrNwL2muzW66tVaVwg+Eo7ytbFGtcv55GmspxlLraCECfdyZELX7c1mAQK0bTCnwxgkDl8fIZhkjruO4+mSgntfjCXRjcmt2C9c301yz+eT/sbgFTZNNYw19IQXCqd13cnVY+bkqwOZ71TuFUAr9vJ+S8D39wIBkxmOrIjW9sAE+42IOOTzhyj3n/bgy9eiZOZ5FCE=;25:ubHNfMnl/DkRiw+vzH8tnEUeeePxRqi0SnvMDpMgnOd62tjp7aQ5Q2HsymJJtvCgaNv4CS/9A3T7VzTjraguG2+bTJAKxLGnzPMIsqDH2i/K9dL3bn4XG+3KqQ5E7PIS+lKCYpyP8PU4q4Tap81zKi9n6Oa4zgLhFVJaMUVcz9PWJMYKG1m/eS2AkW+zPCA4NhrUDcTmHq/zfJP5ukX438W9MFHWYBXCm78thGxqRUNnonQKAd4hQcn5ee49d87ZBKxBrd9hNHG7qoLeF2piCvvW8XwAoV5TawKleH0flSWxL+HCjTylnOZAmkjXCR5MBvU7KElmOP4x4z3BUXCzx56LrQu6KAhVE8/xWhfz/d8Izt0Yk4UkW9NtOCtPxcHWy+rZ4qepsas5yORvX/zMxW8vdBq+7KNNz485aq0jbLsHpRtT33qF06VRVYnRglpYvYqiEtA6aKu7lBl+sWDXU3wLkSHezmEsXMbrn2y0hX3XFT0iLH2zJ6g9Pz5KbYFH X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0855; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0855;20:ZJuAe2vRloLMSQY7rFhjYZ/Q1xMOwBhPiBjX2JkNNr2MGuQm81m5qJi7CKRnYoQn+Z6Hj26VHaFKLa/VuSnWaG5kP1CNBPiQ9wGNSX3rlI4Y1eCRI+MQuDhGgjkYK1V/67bQ62KSR5r74sVYt9O+BlXx14+8OVVKzw8hM7410VaXMfxMINv1NV5uXUDGQiOzr1bLhmpBAWO68MT7oJRZEzakQvsvXNjsB1nfh1PZ9NqdmCg+PdQZYJG+/JDIY8vVv6w+haOrSRxIP5qOVVROJCSodNssIxvOpct8vsRnKA2sI4jTbDUGLzg/Xzw5ZkXDYV+YNXdZk7oGiucXfRJ8gK7zAaB6ZIy5GkdO7S+rq2hd92inBS2FwXN7ytTQDGKyGOFoN0OCNIoolV5b/S/fUU0p3PbimTnUI3vspNzVGrrSDS6EkgOgs88w40V6QsbmkqXjc3tYHcdwy4NRLpp5v2k1tHtDRaF+UdClFQWvaJgIW/XsPfu3HQnOFbTUfQYt X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(8121501046)(5005006)(13024025)(13017025)(13015025)(13023025)(3002001)(10201501046);SRVR:CY1PR12MB0855;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0855; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0855;4:3CM/rR11EJDzbMcW61BbqMaDqsRvvMvBiTZgqmACGdATEueaJ0MAGIQJmCbRF78qpRyrFt9K4D3XciHM1NdeIBEVX/Nr7OrhOrIX8s6BsN9sDbrQyrfvpJ9B43jWawxrLnNsRoytZ7FoL180FyrRePewdskLSvOp3XLpJvXmYlZe6i4y1m4EkeYdpYxDISG2mIbZNBEbQhygKnaYBVtzsUZf9MSNq0K6ZegGF28VDlSjX4Yspd1Vo/zvMA5mgrH9O5+lRo4R7hcFjUYW0z6oeY1xJ2A5AvsI85oG65wtPnoklAasZZVQ48VjgBb0UPYM11ajkgccDrB4dYvW01iLqFkkWzwTQ+D3enLpxxfIiRv+Q+2zru/JF9RXUL3xCqRMvM3Moz2GA67pg0FIPPg9yvexNssq/CIsSQDBGMOOqhgYVxcrPTFJUk0zPrpkQI/LnzcmJvCQiD/qB2nAEH9z/A== X-Forefront-PRVS: 0888B1D284 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR12MB0855;23:ENmAmkwDOAfcW5NUQdCDH0UTaif0zqo4A+UKa2QCp?= =?us-ascii?Q?2uWK3JAAkKX10AEx6KjmilXvMgBlw5+a5x6oxMd+UZ7EauM9ahKznEQ7VWhN?= =?us-ascii?Q?Rb80Fmhf5p/GXbfzK9IS4QPOdEaHYQ94EIXyowf/TPXhm42gK6ADLVYvJ85X?= =?us-ascii?Q?ELwDAfGJ8rwcaVaqJn+Fx0/vSWjiPm5psIOMy+nEqGze+NBYsfrnSrIHPpje?= =?us-ascii?Q?v922DXtBcBIrmMTOqnO4SDYpTJGUNZUcPgt4Vr326wCGczkWnl7PB+Ozukl2?= =?us-ascii?Q?jZQYOqQc3JgePhzajSHaYWTek2FbElOHr3JSc9D2Oo3vMR1vI4tIJ1pwIKzw?= =?us-ascii?Q?nW6WWuqGTpG/Faeq16zhRIaTZ/nbLujgD6C8X7WzyuATzf36IsAuhAGlP3sW?= =?us-ascii?Q?mzmsj91iBwuzCm49Kf/fHvDhFIzzY0UuJrwjEQnZRJ3sdFjr7OzkwiQMXefm?= =?us-ascii?Q?hRkmBx5DF0HWwA+c3JUrKqbxDsJuCJpQYJQdVMtSdndj3KChTYexx3VGQ7lF?= =?us-ascii?Q?NJ9SSzlmaneyh/TrKifjAdjnZrdU67frghJOD4+Gq4MLGpeYQfFNcHo02Q3U?= =?us-ascii?Q?Kdc9HdIJ0E+MLvu96xQo5vzuG91k7uD8Fs8I6Nh0bB2oRBfO7iPKIGaNP7Sc?= =?us-ascii?Q?uMbI7Ry+O5DS9YzHMwCciy6YCiDjtwnDDNrV5oWk8PJ8UFrYstd51YuMgDeH?= =?us-ascii?Q?fhw7fZoh5TpRNLjck83NVd+DB+oDgm9AvERQUtu7HEQLH9ZQ474x49RpkcVS?= =?us-ascii?Q?eh7PaTMCECmN5IYqN8jTrUSua1ZmIVKaW+EzFaYSEQPja9RurA4aFeEP819x?= =?us-ascii?Q?tHfUAnNtwmu2Pnf5Nx+QzI6eh/SeQWCSf3YSyt3dRtDYy2D0eIU8J60E42h8?= =?us-ascii?Q?KgCc5tRirqcHrEfZMWvWYaos4vh2TkunQ0azsyHc4hAwXF6JW5oLe69kvhJJ?= =?us-ascii?Q?Yfh9iD5n1tz4aJBFBr5vu2NdbiHE4WPnFUwRZK/W7DSdKCtt7LoBJnNUeXdt?= =?us-ascii?Q?QaScdAXw21afTyg5NWc7Sgy7DQwdjcMD9fkQJKvpD+agJFG2jtwoXWiS0lbR?= =?us-ascii?Q?BWDGfZZJHBSLxAIDPpwOLHR915k?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0855;5:DbMNPcUgQGLdhEqSONVC4I3OWiNldw4fpSfnGYBzdFHwU8dTYxAxsA/ZCfaOsH104KoTIXRYyDXnxUxo5DbDTck7OH1w3VyniTQwfykllWAaNn+hNEcpXPlmk7WQ353IMdyOP1qLJsok/f/qS3/82w==;24:j1+puJH9eHMXcSM3eKGkwMHg8KYUJX3kovhZog962Za4FKJdcbPXQGI1ELi4D7hCTbHHfOF7bUwe6nNZF0uXaJ/AsllRAavvcRh1Pz/Soqs=;20:AGVmPEqRrPVJG8wFPqd62D56N87136P9+nmFHMNzgJJ3r9L45/BzQbUaX8R9zGnFoDZ/x7L7AjHLwvXNotsaF7q5jRHqW0k58Ix23zrOXqosRC9R/wqCrop89Qy2Sd/ugOVzwvdl1EPkLs4bhqz9a7v4sdCil9f6sRo7vJDnuAuVQRkCw8mU/HogFWJC6x0NDqR5FcyaREeTCO28Y8jHptvvVO4rlJawkimG1w6r7064AH3fupIyDRMXhm3Bt1tg SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2016 09:17:47.9458 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0855 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 21, 2016 at 09:26:43AM +0100, Borislav Petkov wrote: > On Mon, Mar 21, 2016 at 11:46:19AM +0800, Huang Rui wrote: > > I quickly applied this patch on tip/master with on a fam15h machine. > > The issue is still existed, only one core can be detected. > > Huh, what? > > So that 6386 has 16 cores, according to wikipedia, that must be 8 > compute units. Correct? > Yes, there are two sockets in this platform. 32 cores and 16 compute units. > Are you saying, you have only one core in /proc/cpuinfo? > > Can you send full dmesg please? > Apology to bring a surprise. Our test machine didn't configure the CONFIG_SMP just now because it was to reproduce another build issue before... So an incorrect "only one" core is detected, sorry. Please ignore previous result. I will do more testing on other platforms. Now I re-build system, please see the correct message: ray@hr-ub:~/tip$ cat /sys/devices/system/cpu/cpu2/topology/thread_siblings_list 2-3 ray@hr-ub:~/tip$ cat /sys/devices/system/cpu/cpu2/topology/core_siblings_list 0-15 processor : 31 vendor_id : AuthenticAMD cpu family : 21 model : 2 model name : AMD Opteron(tm) Processor 6386 SE stepping : 0 microcode : 0x6000822 cpu MHz : 1400.000 cache size : 2048 KB physical id : 1 siblings : 16 core id : 7 cpu cores : 8 apicid : 79 initial apicid : 47 fpu : yes fpu_exception : yes cpuid level : 13 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc extd_apicid amd_dcm aperfmperf eagerfpu pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 popcnt aes xsave avx f16c lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs xop skinit wdt lwp fma4 tce nodeid_msr tbm topoext perfctr_core perfctr_nb cpb hw_pstate vmmcall bmi1 arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold bugs : fxsave_leak sysret_ss_attrs bogomips : 5585.90 TLB size : 1536 4K pages clflush size : 64 cache_alignment : 64 address sizes : 48 bits physical, 48 bits virtual power management: ts ttp tm 100mhzsteps hwpstate cpb eff_freq_ro Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian CPU(s): 32 On-line CPU(s) list: 0-31 Thread(s) per core: 2 Core(s) per socket: 8 Socket(s): 2 NUMA node(s): 4 Vendor ID: AuthenticAMD CPU family: 21 Model: 2 Stepping: 0 CPU MHz: 1400.000 BogoMIPS: 5585.90 Virtualization: AMD-V L1d cache: 16K L1i cache: 64K L2 cache: 2048K L3 cache: 6144K NUMA node0 CPU(s): 0-7 NUMA node1 CPU(s): 8-15 NUMA node2 CPU(s): 16-23 NUMA node3 CPU(s): 24-31 Thanks, Rui