From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754959AbcCULLO (ORCPT ); Mon, 21 Mar 2016 07:11:14 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49652 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcCULLK (ORCPT ); Mon, 21 Mar 2016 07:11:10 -0400 Date: Mon, 21 Mar 2016 11:11:00 +0000 From: Mark Brown To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Liam Girdwood Message-ID: <20160321111100.GN2566@sirena.org.uk> References: <1458527986-4576-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ttldl3tz4cUGhF4e" Content-Disposition: inline In-Reply-To: <1458527986-4576-1-git-send-email-javier@osg.samsung.com> X-Cookie: Walk softly and carry a megawatt laser. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: Lookup unresolved parent supplies before regulators cleanup X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ttldl3tz4cUGhF4e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Mar 20, 2016 at 11:39:46PM -0300, Javier Martinez Canillas wrote: > Unfortunately, that changed the behavior of the regulator core since now a > parent supply with a child regulator marked as always-on, won't be enabled > unless a client driver attempts to get the child regulator during boot. > This patch makes the unresolved parent supplies to be looked up before the > regulators late cleanup, so those with a child marked as always on will be > enabled regardless if a driver attempted to get the child regulator or not. This doesn't make much sense to me as a fix - it feels like we're doing a fragile hack. Surely it's better to do this as we register the devices, that way we're also protected against any similar issues with this that might occur after late probe if things are built modular? Or is there a strong reason for doing this only at late_initcall? --ttldl3tz4cUGhF4e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW79WQAAoJECTWi3JdVIfQDb0H/0Y674IQI/VXtR9fU2kY0sN5 XfEKTzp4XkQmB+vrWJTHf8ReFsy+JDt6ICrgjjRdIuD2/c+sKNQ+ed5Bfiry/6l3 jkvwkkRJVQEaTWpP/i83F+7ZUWyZgjnPHroUXaW+y2vgsr8F1xwqtSmXJVHpalo+ d/LYYNRNUkdQ2XuQe2gflfrz8zbROtqE67qJhRYhP9dJWvDijpFkr1KJoUepPUf8 0PzY/Oj9ztjDHgvpO78zs/FVU0cIIo2a8g+6LzP1hcmhtI0X3bHGRj3qRni20+k6 KnTfxOdS3SpgLUlU8p/nWjkLWQCRPm17wYEEpuQSCFX89Yr9/m0QyZXpU53mEgA= =2Zg1 -----END PGP SIGNATURE----- --ttldl3tz4cUGhF4e--