From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
karam.lee@lge.com, sangseok.lee@lge.com, chan.jeong@lge.com
Subject: Re: [PATCH] zram: revive swap_slot_free_notify
Date: Mon, 21 Mar 2016 13:30:17 -0700 [thread overview]
Message-ID: <20160321133017.1e925cc45cdc9153d2623ef8@linux-foundation.org> (raw)
In-Reply-To: <1458287911-24806-1-git-send-email-minchan@kernel.org>
On Fri, 18 Mar 2016 16:58:31 +0900 Minchan Kim <minchan@kernel.org> wrote:
> <b430e9d1c6d4> "remove compressed copy from zram in-memory"
> applied swap_slot_free_notify call in *end_swap_bio_read* to
> remove duplicated memory between zram and memory.
>
> However, with introducing rw_page in zram <8c7f01025f7b>
> "zram: implement rw_page operation of zram", it became void
> because rw_page doesn't need bio.
>
> This patch restores the function for rw_page.
This is a bit mysterious. What is the actual runtime effect of the
patch? I assume that 8c7f01025f7b caused duplication of memory and
that the only problem is additional resource consumption? If so, what
are the observable effects? etcetera, please.
next prev parent reply other threads:[~2016-03-21 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 7:58 Minchan Kim
2016-03-21 20:30 ` Andrew Morton [this message]
2016-03-21 23:52 ` Minchan Kim
2016-03-22 5:08 ` Joonsoo Kim
2016-03-22 8:00 ` Minchan Kim
2016-03-22 8:20 ` Joonsoo Kim
2016-03-22 14:06 ` Minchan Kim
2016-03-23 4:45 ` Joonsoo Kim
2016-03-28 4:58 Minchan Kim
2016-03-28 14:30 Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321133017.1e925cc45cdc9153d2623ef8@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chan.jeong@lge.com \
--cc=karam.lee@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sangseok.lee@lge.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome