From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758957AbcCVNSX (ORCPT ); Tue, 22 Mar 2016 09:18:23 -0400 Received: from smtprelay0133.hostedemail.com ([216.40.44.133]:34278 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758421AbcCVNSP (ORCPT ); Tue, 22 Mar 2016 09:18:15 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:2693:2898:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3874:4321:5007:6119:6120:6261:7875:9040:10004:10400:10848:10967:11026:11232:11658:11914:12109:12517:12519:12555:12663:12740:13069:13311:13357:13439:14181:14659:14721:21080:30054:30070:30075:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: jar72_64ee1c6d8773f X-Filterd-Recvd-Size: 1977 Date: Tue, 22 Mar 2016 09:18:11 -0400 From: Steven Rostedt To: Peter Xu Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH trace-cmd 1/2] trace-cmd-listen: remove useless printf Message-ID: <20160322091811.341b2e03@gandalf.local.home> In-Reply-To: <1458632442-6878-2-git-send-email-peterx@redhat.com> References: <1458632442-6878-1-git-send-email-peterx@redhat.com> <1458632442-6878-2-git-send-email-peterx@redhat.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Mar 2016 09:14:14 -0400 Peter Xu wrote: > This line is useless since we will get more verbose info in > do_connection(). Another problem is, we will get this "connected!" line > everytime after we hit "ctrl-c" for "trace-cmd listen". We possibly do > not want that. > > Signed-off-by: Peter Xu > --- > trace-listen.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/trace-listen.c b/trace-listen.c > index 1e38eda..12cc9c5 100644 > --- a/trace-listen.c > +++ b/trace-listen.c > @@ -721,7 +721,6 @@ static void do_accept_loop(int sfd) > do { > cfd = accept(sfd, (struct sockaddr *)&peer_addr, > &peer_addr_len); > - printf("connected!\n"); I probably kept this in for debugging. But I still think there should be some kind of logging here. If anything, change this to a debug print. I'm working on passing in --debug into the command line here, so I'm not going to take this patch. It should be converted to the debug coed. -- Steve > if (cfd < 0 && errno == EINTR) > continue; > if (cfd < 0)