From: Josh Poimboeuf <jpoimboe@redhat.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>
Subject: Re: drivers/target/iscsi/iscsi_target.o: warning: objtool: iscsit_handle_task_mgt_cmd()+0xbcb: function has unreachable instruction
Date: Wed, 23 Mar 2016 16:11:04 -0500 [thread overview]
Message-ID: <20160323211104.akrzp4n2a32anfc3@treble.redhat.com> (raw)
In-Reply-To: <201603231906.LWcVUpxm%fengguang.wu@intel.com>
On Wed, Mar 23, 2016 at 07:15:08PM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: a24e3d414e59ac76566dedcad1ed1d319a93ec14
> commit: d4883d5d6b146fd65f762c462b2c6d4a327c7d50 objtool: Enable stack metadata validation on 64-bit x86
> date: 3 weeks ago
> config: x86_64-randconfig-x014-03231738 (attached as .config)
> reproduce:
> git checkout d4883d5d6b146fd65f762c462b2c6d4a327c7d50
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/target/iscsi/iscsi_target.o: warning: objtool: iscsit_handle_task_mgt_cmd()+0xbcb: function has unreachable instruction
Ingo,
FYI, I'm aware of this issue but I'm not yet sure about the best way to
fix it. I'll be on vacation next week but will try to get to it in a
couple of weeks.
It only seems to manifest itself in certain randconfigs which include
CONFIG_PROFILE_ALL_BRANCHES=y.
more details:
The issue is caused by a sloppy gcc optimization. It looks like gcc
created a jump table for a switch statement, but then decided not to use
it, and failed to clean up its mess. So it
10094: ff 25 00 00 00 00 jmpq *0x0(%rip) # 1009a <iscsit_handle_task_mgt_cmd+0x36a>
10096: R_X86_64_PC32 .rodata+0x3c
There's no
--
Josh
next prev parent reply other threads:[~2016-03-23 21:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 11:15 kbuild test robot
2016-03-23 21:11 ` Josh Poimboeuf [this message]
2016-03-23 21:15 ` Josh Poimboeuf
2016-03-24 8:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323211104.akrzp4n2a32anfc3@treble.redhat.com \
--to=jpoimboe@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®