mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: babu.moger@oracle.com
Cc: bhelgaas@google.com, wangyijing@huawei.com,
	sowmini.varadhan@oracle.com, jiang.liu@linux.intel.com,
	eric.snowberg@oracle.com, yinghai@kernel.org,
	dan.j.williams@intel.com, sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	ethan.zhao@oracle.com
Subject: Re: [PATCH v3] sparc/PCI: Fix for panic while enabling SR-IOV
Date: Thu, 24 Mar 2016 15:16:54 -0400 (EDT)	[thread overview]
Message-ID: <20160324.151654.1707693980081136191.davem@davemloft.net> (raw)
In-Reply-To: <1458772676-47866-1-git-send-email-babu.moger@oracle.com>

From: Babu Moger <babu.moger@oracle.com>
Date: Wed, 23 Mar 2016 15:37:56 -0700

> +#ifdef CONFIG_PCI_IOV
> +int pcibios_add_device(struct pci_dev *dev)
> +{
> +	struct pci_dev *pdev;
> +	/*
> +	 * Add sriov arch specific initialization here.
> +	 * Copy dev_archdata from PF to VF
> +	 */

Always have an empty line after a set of local variable declarations.

Sparc code is to have comments formatted:

	/* Like
	 * this.
	 */

> +		memcpy(&dev->dev.archdata, &pdev->dev.archdata,
> +				sizeof(struct dev_archdata));

Sparc code should indent multi-line expressions by having the second
and subsequent line be indented exactly to the column following the
openning parenthesis on the first line.

You must use the appropriate number of TAB then SPACE characters
necessary to do so.

Thanks.

      reply	other threads:[~2016-03-24 19:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 22:37 Babu Moger
2016-03-24 19:16 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160324.151654.1707693980081136191.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=babu.moger@oracle.com \
    --cc=bhelgaas@google.com \
    --cc=dan.j.williams@intel.com \
    --cc=eric.snowberg@oracle.com \
    --cc=ethan.zhao@oracle.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sowmini.varadhan@oracle.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=wangyijing@huawei.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®